Install Fails

[oytunistrator]

$ npm i -g slap@latest

command fails;

/home/oytun/.npm-global/bin/slap -> /home/oytun/.npm-global/lib/node_modules/slap/slap.js

> marker-index@4.0.0 install /home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index
> node-gyp rebuild

make: Entering directory '/home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index/build'
  CXX(target) Release/obj.target/marker_index/src/native/iterator.o
  CXX(target) Release/obj.target/marker_index/src/native/marker-index-wrapper.o
In file included from ../src/native/marker-index-wrapper.cc:2:
../../nan/nan.h: In function ‘void Nan::AsyncQueueWorker(Nan::AsyncWorker*)’:
../../nan/nan.h:2232:62: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
     , reinterpret_cast<uv_after_work_cb>(AsyncExecuteComplete)
                                                              ^
../src/native/marker-index-wrapper.cc: In static member function ‘static Nan::Maybe<Point> MarkerIndexWrapper::PointFromJS(Nan::MaybeLocal<v8::Object>)’:
../src/native/marker-index-wrapper.cc:112:54: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
       row = static_cast<unsigned>(js_row->Int32Value());
                                                      ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/v8.h:26,
                 from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:2572:46: note: declared here
   V8_DEPRECATED("Use maybe version", int32_t Int32Value() const);
                                              ^~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/native/marker-index-wrapper.cc:118:60: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
       column = static_cast<unsigned>(js_column->Int32Value());
                                                            ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/v8.h:26,
                 from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:2572:46: note: declared here
   V8_DEPRECATED("Use maybe version", int32_t Int32Value() const);
                                              ^~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/native/marker-index-wrapper.cc: In static member function ‘static bool MarkerIndexWrapper::IsFinite(v8::Local<v8::Integer>)’:
../src/native/marker-index-wrapper.cc:128:92: error: no matching function for call to ‘v8::Object::CallAsFunction(v8::Local<v8::Primitive>, int, v8::Local<v8::Value> [1])’
     Local<Value> result = Nan::New(is_finite_function)->CallAsFunction(Nan::Null(), 1, argv);
                                                                                            ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:3728:43: note: candidate: ‘v8::MaybeLocal<v8::Value> v8::Object::CallAsFunction(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*)’
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> CallAsFunction(Local<Context> context,
                                           ^~~~~~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:3728:43: note:   candidate expects 4 arguments, 3 provided
../src/native/marker-index-wrapper.cc:129:33: warning: ‘bool v8::Value::BooleanValue() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return result->BooleanValue();
                                 ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/v8.h:26,
                 from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:2568:43: note: declared here
   V8_DEPRECATED("Use maybe version", bool BooleanValue() const);
                                           ^~~~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/native/marker-index-wrapper.cc: In static member function ‘static Nan::Maybe<unsigned int> MarkerIndexWrapper::MarkerIdFromJS(Nan::MaybeLocal<v8::Integer>)’:
../src/native/marker-index-wrapper.cc:171:70: warning: ‘uint32_t v8::Value::Uint32Value() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     return Nan::Just<MarkerId>(static_cast<MarkerId>(id->Uint32Value()));
                                                                      ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/v8.h:26,
                 from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:2571:47: note: declared here
   V8_DEPRECATED("Use maybe version", uint32_t Uint32Value() const);
                                               ^~~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/native/marker-index-wrapper.cc: In constructor ‘MarkerIndexWrapper::MarkerIndexWrapper(v8::Local<v8::Number>)’:
../src/native/marker-index-wrapper.cc:331:57: warning: ‘int32_t v8::Value::Int32Value() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
     marker_index{static_cast<unsigned>(seed->Int32Value())} {}
                                                         ^
In file included from /home/oytun/.node-gyp/11.9.0/include/node/v8.h:26,
                 from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:2572:46: note: declared here
   V8_DEPRECATED("Use maybe version", int32_t Int32Value() const);
                                              ^~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8config.h:326:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
In file included from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
../src/native/marker-index-wrapper.cc: At global scope:
/home/oytun/.node-gyp/11.9.0/include/node/node.h:495:43: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Object>)’ to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
       (node::addon_register_func) (regfunc),                          \
                                           ^
/home/oytun/.node-gyp/11.9.0/include/node/node.h:529:3: note: in expansion of macro ‘NODE_MODULE_X’
   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
   ^~~~~~~~~~~~~
../src/native/marker-index-wrapper.cc:348:1: note: in expansion of macro ‘NODE_MODULE’
 NODE_MODULE(marker_index, MarkerIndexWrapper::Init)
 ^~~~~~~~~~~
In file included from /home/oytun/.node-gyp/11.9.0/include/node/node.h:63,
                 from ../../nan/nan.h:53,
                 from ../src/native/marker-index-wrapper.cc:2:
/home/oytun/.node-gyp/11.9.0/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)]’:
/home/oytun/.node-gyp/11.9.0/include/node/node_object_wrap.h:85:78:   required from here
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:9707:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
                reinterpret_cast<Callback>(callback), type);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/oytun/.node-gyp/11.9.0/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = Nan::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)]’:
../../nan/nan_object_wrap.h:66:61:   required from here
/home/oytun/.node-gyp/11.9.0/include/node/v8.h:9707:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<Nan::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
make: *** [marker_index.target.mk:109: Release/obj.target/marker_index/src/native/marker-index-wrapper.o] Error 1
make: Leaving directory '/home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:197:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Linux 4.20.6-arch1-1-ARCH
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index
gyp ERR! node -v v11.9.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! marker-index@4.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the marker-index@4.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/oytun/.npm/_logs/2019-02-08T11_14_40_409Z-debug.log

/home/oytun/.npm/_logs/2019-02-08T11_14_40_409Z-debug.log last lines;

9016 silly install marker-index@4.0.0
9017 info lifecycle marker-index@4.0.0~install: marker-index@4.0.0
9018 verbose lifecycle marker-index@4.0.0~install: unsafe-perm in lifecycle true
9019 verbose lifecycle marker-index@4.0.0~install: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index/node_modules/.bin:/home/oytun/.npm-global/lib/node_modules/slap/node_modules/.bin:/home/oytun/.npm-global/lib/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/oytun/go/bin:/home/oytun/.config/composer/vendor/bin
9020 verbose lifecycle marker-index@4.0.0~install: CWD: /home/oytun/.npm-global/lib/node_modules/slap/node_modules/marker-index
9021 silly lifecycle marker-index@4.0.0~install: Args: [ '-c', 'node-gyp rebuild' ]
9022 silly lifecycle marker-index@4.0.0~install: Returned: code: 1  signal: null
9023 info lifecycle marker-index@4.0.0~install: Failed to exec install script
9024 timing action:install Completed in 2429ms
9025 verbose unlock done using /home/oytun/.npm/_locks/staging-1ae234b2bda2efa6.lock for /home/oytun/.npm-global/lib/node_modules/.staging
9026 timing stage:rollbackFailedOptional Completed in 605ms
9027 timing stage:runTopLevelLifecycles Completed in 8791ms
9028 verbose stack Error: marker-index@4.0.0 install: `node-gyp rebuild`
9028 verbose stack Exit status 1
9028 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
9028 verbose stack     at EventEmitter.emit (events.js:197:13)
9028 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
9028 verbose stack     at ChildProcess.emit (events.js:197:13)
9028 verbose stack     at maybeClose (internal/child_process.js:978:16)
9028 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
9029 verbose pkgid marker-index@4.0.0
9030 verbose cwd /home/oytun
9031 verbose Linux 4.20.6-arch1-1-ARCH
9032 verbose argv "/usr/bin/node" "/usr/bin/npm" "i" "-g" "slap@latest"
9033 verbose node v11.9.0
9034 verbose npm  v6.7.0
9035 error code ELIFECYCLE
9036 error errno 1
9037 error marker-index@4.0.0 install: `node-gyp rebuild`
9037 error Exit status 1
9038 error Failed at the marker-index@4.0.0 install script.
9038 error This is probably not a problem with npm. There is likely additional logging output above.
9039 verbose exit [ 1, true ]

[smketterer]

Same issue here.

[hjalmarlucius]

same here

[nateGeorge]

What about the other install method?

curl -sL https://raw.githubusercontent.com/slap-editor/slap/master/install.sh | sh

It worked on Ubuntu 18.04 (npm must still be installed).

[oytunistrator]

same;

# Installing slap...
/usr/local/bin/slap -> /usr/local/lib/node_modules/slap/slap.js

> marker-index@4.0.0 install /usr/local/lib/node_modules/slap/node_modules/marker-index
> node-gyp rebuild

gyp WARN EACCES user "root" does not have permission to access the dev dir "/home/oytun/.node-gyp/8.11.4"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/usr/local/lib/node_modules/slap/node_modules/marker-index/.node-gyp"
gyp WARN install got an error, rolling back install
gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/slap/node_modules/marker-index/.node-gyp'
gyp ERR! System Linux 4.18.0-17-generic
gyp ERR! command "/usr/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/slap/node_modules/marker-index
gyp ERR! node -v v8.11.4
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! marker-index@4.0.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the marker-index@4.0.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/oytun/.npm/_logs/2019-04-18T19_53_25_940Z-debug.log

[cancerberoSgx]

The problem is with text-buffer dependency and node-inspector (dev-dependency). I upgraded everything to latest (in three projects slap, editor-widget, base-widget)

https://github.com/cancerberoSgx/slap

It currently doesn't work with node 12 so you have to use 11 or and it works with node.js 11 or older (it currently doesn't work with node.js 12 - working on that), so these are instructions to use nave node version manager (you could use nvm, n etc):

npm i nave
npx nave use 11
npm i cancerberosgx/slap
npx slap .

[oliver-daniel]

@nateGeorge that also won't work. The only thing it seems to work is to downgrade to node 6.x and compile with that..

The problem is with text-buffer dependency and node-inspector (dev-dependency). I upgraded everything to latest (in three projects slap, editor-widget, base-widget) and it compiled without problems. using latest node.

After small incompatibilities fixed have it working with latest dependencies and node version: https://github.com/cancerberoSgx/slap

For installing globally the following should work:

npm i -g git+https://github.com/cancerberoSgx/slap.git

My two cents. (will PR to several projects, but I doubt there's something maintaining it ? Also, IMHO, it makes more sense to have a mono repo with the projects inside.

This is unfortunately broken in Jun 2019. It seems to break in almost the same way, here complaining about the install script of superstring@2.3.6; any ideas?

[oliver-daniel]

Just tried

npm i -g git+https://github.com/cancerberoSgx/slap.git

and it did worked fine for me in mac and linux - node 12. You need to have C/C++ make gmake dev tools installed , superstring is the support for atom editor's buffer (text-buffer) written in C/C++ ... that's what slap is using. I upgraded to latest some month ago and slap worked fine... perhaps paste the error ? Thanks

Certainly.

CXX(target) Release/obj.target/superstring/src/bindings/marker-index-wrapper.o
../src/bindings/marker-index-wrapper.cc:73:92: error: too few arguments to
      function call, single argument 'context' was not specified
  ...constructor_template->GetFunction());
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:5947:3: note: 'GetFunction'
      declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/bindings/marker-index-wrapper.cc:113:15: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    js_array->Set(i, Nan::New<Integer>(marker_ids[i]));
              ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3367:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:122:12: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    range->Set(Nan::New(start_string), PointWrapper::from_point(pair.sec...
           ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:123:12: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    range->Set(Nan::New(end_string), PointWrapper::from_point(pair.second.end));
           ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:124:20: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    result_object->Set(Nan::New<Integer>(pair.first), range);
                   ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:210:18: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    invalidated->Set(Nan::New(touch_string), marker_ids_set_to_js(result...
                 ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:211:18: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    invalidated->Set(Nan::New(inside_string), marker_ids_set_to_js(resul...
                 ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:212:18: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    invalidated->Set(Nan::New(inside_string), marker_ids_set_to_js(resul...
                 ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:213:18: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    invalidated->Set(Nan::New(overlap_string), marker_ids_set_to_js(resu...
                 ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:214:18: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    invalidated->Set(Nan::New(surround_string), marker_ids_set_to_js(res...
                 ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:246:13: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    result->Set(Nan::New(start_string), PointWrapper::from_point(range.start));
            ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:247:13: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    result->Set(Nan::New(end_string), PointWrapper::from_point(range.end));
            ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:350:43: error: too few arguments to
      function call, single argument 'context' was not specified
    max_count = js_max_count->NumberValue();
                ~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:2564:3: note: 'NumberValue'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/bindings/marker-index-wrapper.cc:356:16: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    js_result->Set(Nan::New(containing_start_string), marker_ids_vector_...
               ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:362:20: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
      js_boundary->Set(Nan::New(position_string), PointWrapper::from_poi...
                   ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:363:20: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
      js_boundary->Set(Nan::New(starting_string), marker_ids_set_to_js(b...
                   ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:364:20: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
      js_boundary->Set(Nan::New(ending_string), marker_ids_set_to_js(bou...
                   ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:365:22: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
      js_boundaries->Set(i, js_boundary);
                     ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3367:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/bindings/marker-index-wrapper.cc:367:16: warning: 'Set' is deprecated:
      Use maybe version [-Wdeprecated-declarations]
    js_result->Set(Nan::New(boundaries_string), js_boundaries);
               ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been
      explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/Oliver/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded
      from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
17 warnings and 2 errors generated.
make: *** [Release/obj.target/superstring/src/bindings/marker-index-wrapper.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:200:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.6.0
gyp ERR! command "/usr/local/lib/node_modules/node/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/slap/node_modules/superstring
gyp ERR! node -v v12.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! superstring@2.3.6 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the superstring@2.3.6 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

[pixelein]

@oliver-daniel same here

[cancerberoSgx]

@iayaz @oliver-daniel - my fork - cancerberosgx/slap currently doesn't work with node 12 - only 11 and older (i'm working on it). I updated install instructions in my original comment #411 (comment)

[cancerberoSgx]

update: this is now the dependency not supporting node 12 - atom/superstring#75
waiting for it. I will probably grab all dependencies in a mono-repo to have more control since This seems to be common in this kind of projects, anybody interested on joining efforts / suggestions ?

[sidneys]

update: this is now the dependency not supporting node 12 - atom/superstring#75
waiting for it. I will probably grab all dependencies in a mono-repo to have more control since This seems to be common in this kind of projects, anybody interested on joining efforts / suggestions ?

Dear @cancerberoSgx
Dear @oliver-danielm, @alicesypark

Based on your work i followed up on all the issues pertaining to upstream build failures in a NodeJS 12 context, also stumpeling onto other issues in the dependency chain (like unreferenced required binaries & build tools @ atom/text-buffer), which thwarted successful builds in a perfect dependency-hell clusterf*ck.

It required forking 5 repos (text-buffer, base-widget, slap, superstring, editor-widget) - but it worked in the end. I started the work off of @cancerberoSgx 's fork, and then went from there. I can create PRs if desired.

To install slap globally, under NodeJS 12, simply do (via my GitHub repo):

npm install --global git+https://github.com/sidneys/slap.git#master

Cheers,
Looking forward to your Feedback.
S

[MuhammadSawalhy]

See this issue, I have answered it, #414

[darkguy2008]

This project seemed like it was the solution to all my terminal editing woes, but installing it is a slap in the face. I can't believe the install process is so messy :(

@sidneys your solution sadly isn't compatible with Node LTS v14.

So sad.

[essenciary]

@darkguy2008 Wow, such entitlement. Here's a thought: why don't you use your smarts for the good of the community (and yourself) and contribute a better install process?