Docs for `PlainSecondsLog` incorrectly says that the harness expects milliseconds when it actually expects seconds

[jordanmontt]

The harness name of PlainSecondsLog indicates that the benchmark should return the measurements as seconds. But, in the description it clearly says that it expects milliseconds actually.

This adapter attempts to read every line of program output as a millisecond measurement

[smarr]

Hm, looking at the implementation, it takes the value and multiplies by 1000:

ReBench/rebench/interop/plain_seconds_log_adapter.py

Line 55 in e1be4e2

time = float(line) * 1000

I suspect you're referring to the sentence here?

ReBench/docs/extensions.md

Line 22 in e1be4e2

This adapter attempts to read every line of program output as a millisecond

Looks like this is wrong since the multiplication in the implementation seems to be done unconditionally.

[jordanmontt]

OK! So the harness does actually expects seconds. The sentence in the docs is wrong. I will change the title of the issue

[smarr]

@jordanmontt does #293 fix things for you?

[jordanmontt]

@smarr Yes!

[smarr]

Thanks for reporting. Merged and docs are updated online: https://rebench.readthedocs.io/en/latest/extensions/