fix naming

Author: smdn

src/Smdn.Net.AddressResolution/Smdn.Net.AddressResolution.Arp/ProcfsArpMacAddressResolver.cs

@@ -32,10 +32,10 @@ internal partial class ProcfsArpMacAddressResolver : MacAddressResolver {
       );
     }
 
-    if (ProcfsArpNmapScanMacAddressResolver.IsSupported) {
-      return new ProcfsArpNmapScanMacAddressResolver(
+    if (ProcfsArpWithNmapCommandMacAddressResolver.IsSupported) {
+      return new ProcfsArpWithNmapCommandMacAddressResolver(
         options: options,
-        logger: serviceProvider?.GetService<ILoggerFactory>()?.CreateLogger<ProcfsArpNmapScanMacAddressResolver>()
+        logger: serviceProvider?.GetService<ILoggerFactory>()?.CreateLogger<ProcfsArpWithNmapCommandMacAddressResolver>()
       );
     }
 

src/Smdn.Net.AddressResolution/Smdn.Net.AddressResolution.Arp/ProcfsArpWithNmapCommandMacAddressResolver.cs

@@ -12,7 +12,7 @@
 
 namespace Smdn.Net.AddressResolution.Arp;
 
-internal sealed class ProcfsArpNmapScanMacAddressResolver : ProcfsArpMacAddressResolver {
+internal sealed class ProcfsArpWithNmapCommandMacAddressResolver : ProcfsArpMacAddressResolver {
   // ref: https://nmap.org/book/man-briefoptions.html
   //   -sn: Ping Scan - disable port scan
   //   -n: Never do DNS resolution
@@ -21,12 +21,12 @@ internal sealed class ProcfsArpNmapScanMacAddressResolver : ProcfsArpMacAddressR
   //   -oG <file>: Output scan in Grepable format
   private const string NmapCommandBaseOptions = "-sn -n -T4 -oG - ";
 
-  public static new bool IsSupported => ProcfsArpMacAddressResolver.IsSupported && lazyPathToNmap.Value is not null;
+  public static new bool IsSupported => ProcfsArpMacAddressResolver.IsSupported && lazyPathToNmapCommand.Value is not null;
 
-  private static readonly Lazy<string?> lazyPathToNmap = new(valueFactory: GetPathToNmap, isThreadSafe: true);
+  private static readonly Lazy<string?> lazyPathToNmapCommand = new(valueFactory: GetPathToNmapCommand, isThreadSafe: true);
   private static readonly string[] BinDirs = new[] { "/bin/", "/sbin/", "/usr/bin/" };
 
-  private static string? GetPathToNmap()
+  private static string? GetPathToNmapCommand()
     => BinDirs
       .Select(static dir => Path.Combine(dir, "nmap"))
       .FirstOrDefault(static nmap => File.Exists(nmap));
@@ -37,7 +37,7 @@ internal sealed class ProcfsArpNmapScanMacAddressResolver : ProcfsArpMacAddressR
   private readonly string nmapCommandCommonOptions;
   private readonly string nmapCommandFullScanOptions;
 
-  public ProcfsArpNmapScanMacAddressResolver(
+  public ProcfsArpWithNmapCommandMacAddressResolver(
     MacAddressResolverOptions options,
     ILogger? logger
   )
@@ -46,22 +46,22 @@ public ProcfsArpNmapScanMacAddressResolver(
       logger
     )
   {
-    if (string.IsNullOrEmpty(options.NmapInterfaceSpecification))
+    if (string.IsNullOrEmpty(options.NmapCommandInterfaceSpecification))
       nmapCommandCommonOptions = NmapCommandBaseOptions;
     else
       // -e <iface>: Use specified interface
-      nmapCommandCommonOptions = NmapCommandBaseOptions + $"-e {options.NmapInterfaceSpecification} ";
+      nmapCommandCommonOptions = NmapCommandBaseOptions + $"-e {options.NmapCommandInterfaceSpecification} ";
 
     nmapCommandFullScanOptions = string.Concat(
       nmapCommandCommonOptions,
-      options.NmapTargetSpecification
-        ?? throw new ArgumentException($"{nameof(options.NmapTargetSpecification)} must be specified with {nameof(MacAddressResolverOptions)}")
+      options.NmapCommandTargetSpecification
+        ?? throw new ArgumentException($"{nameof(options.NmapCommandTargetSpecification)} must be specified with {nameof(MacAddressResolverOptions)}")
     );
   }
 
   protected override ValueTask ArpFullScanAsyncCore(CancellationToken cancellationToken)
     // perform full scan
-    => NmapScanAsync(
+    => RunNmapCommandAsync(
       nmapCommandOptions: nmapCommandFullScanOptions,
       logger: Logger,
       cancellationToken: cancellationToken
@@ -77,21 +77,21 @@ CancellationToken cancellationToken
 
     return nmapCommandOptionTargetSpecification.Length == 0
       ? default // do nothing
-      : NmapScanAsync(
+      : RunNmapCommandAsync(
           nmapCommandOptions: nmapCommandCommonOptions + nmapCommandOptionTargetSpecification,
           logger: Logger,
           cancellationToken: cancellationToken
         );
   }
 
-  private static async ValueTask NmapScanAsync(
+  private static async ValueTask RunNmapCommandAsync(
     string nmapCommandOptions,
     ILogger? logger,
     CancellationToken cancellationToken
   )
   {
     var nmapCommandProcessStartInfo = new ProcessStartInfo() {
-      FileName = lazyPathToNmap.Value,
+      FileName = lazyPathToNmapCommand.Value,
       Arguments = nmapCommandOptions,
       RedirectStandardOutput = true,
       RedirectStandardError = true,

src/Smdn.Net.AddressResolution/Smdn.Net.AddressResolution/MacAddressResolverOptions.cs

@@ -10,12 +10,12 @@ public sealed class MacAddressResolverOptions {
   /// <summary>
   /// Gets the string value passed to the argument '-e &lt;iface&gt;' of nmap command.
   /// </summary>
-  public string? NmapInterfaceSpecification { get; init; }
+  public string? NmapCommandInterfaceSpecification { get; init; }
 
   /// <summary>
   /// Gets the string value passed to the argument &lt;target specification&gt; of nmap command.
   /// </summary>
-  public string? NmapTargetSpecification { get; init; }
+  public string? NmapCommandTargetSpecification { get; init; }
 
   /// <summary>
   /// Gets the string value passed to the argument '--interface=&lt;s&gg;' of arp-scan command.

tests/Smdn.Net.AddressResolution/Smdn.Net.AddressResolution/MacAddressResolver.Create.cs

@@ -13,7 +13,7 @@ public void Create()
   {
     if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && File.Exists("/proc/net/arp")) {
       var options = new MacAddressResolverOptions() {
-        NmapTargetSpecification = "127.0.0.1"
+        NmapCommandTargetSpecification = "127.0.0.1"
       };
       var resolver = MacAddressResolver.Create(options);