ignore 'mscorlib' also for .NETStandard and .NETCoreApp targetted assembly

Author: smdn

src/Smdn.Reflection.ReverseGenerating.ListApi.Core/Smdn.Reflection.ReverseGenerating.ListApi/RuntimeAssemblyName.cs

@@ -53,36 +53,34 @@ private static bool ShouldWarnIfNotToBeAbleToResolve(AssemblyName name, Dependen
     var isTargetNetCore = depContext.Target.Framework.StartsWith(".NETCoreApp,", StringComparison.Ordinal);
 
     if (isTargetNetStandard || isTargetNetCore) {
-      if (
-        string.Equals(name.Name, "netstandard", StringComparison.Ordinal) &&
-        string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase)
-      ) {
-        return shouldNotWarn;
-      }
     }
 
-    var isNameStartsWithOrEqualToSystem =
-      string.Equals(name.Name, "System", StringComparison.Ordinal) ||
-      name.Name.StartsWith("System.", StringComparison.Ordinal);
+    if (isTargetNetStandard || isTargetNetCore) {
+      var isNetStandardAssembly =
+        string.Equals(name.Name, "netstandard", StringComparison.Ordinal) &&
+        string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase);
 
-    if (isNameStartsWithOrEqualToSystem) {
-      if (isTargetNetCore) {
-        if (
-          string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase) ||
-          string.Equals(publicKeyTokenString, PublicKeyTokenMicrosoft, StringComparison.OrdinalIgnoreCase)
-        ) {
-          return shouldNotWarn;
-        }
-      }
+      if (isNetStandardAssembly)
+        return shouldNotWarn;
 
-      if (isTargetNetStandard) {
-        if (
+      var isNameSystemAssembly =
+        string.Equals(name.Name, "System", StringComparison.Ordinal) ||
+        name.Name.StartsWith("System.", StringComparison.Ordinal);
+      var isSystemAssembly =
+        isNameSystemAssembly && (
           string.Equals(publicKeyTokenString, PublicKeyTokenDotnetOpenSource, StringComparison.OrdinalIgnoreCase) ||
           string.Equals(publicKeyTokenString, PublicKeyTokenMicrosoft, StringComparison.OrdinalIgnoreCase)
-        ) {
-          return shouldNotWarn;
-        }
-      }
+        );
+
+      if (isSystemAssembly)
+        return shouldNotWarn;
+
+      var isCoreLibAssembly =
+        string.Equals(name.Name, "mscorlib", StringComparison.Ordinal) &&
+        string.Equals(publicKeyTokenString, "7cec85d7bea7798e" /* CoreLib? */, StringComparison.OrdinalIgnoreCase);
+
+      if (isCoreLibAssembly)
+        return shouldNotWarn;
     }
 
     return shouldWarn;