Skip to content

Conversation

@svij-sc
Copy link
Collaborator

@svij-sc svij-sc commented Apr 23, 2025

Scope of work done

Releasing newest changes introduced internally to open source.
This change should help enable CI/CD too.

This is mainly a copy of internal code (staged from Friday night (Apr 18)) + changed introduced:
go/internal-gigl-pull/489

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Needs Legal/Privacy/Security review?: NO

Ready for code review?: YES

@github-actions
Copy link
Contributor

GiGL Automation

@ 22:00:26UTC : Built and pushed new images:

  • CUDA base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cuda-base:e7390e5bfdb35b8d9492a77b20dac7eba025019d.37.1
  • CPU base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cpu-base:e7390e5bfdb35b8d9492a77b20dac7eba025019d.37.1
  • Dataflow base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-dataflow-base:e7390e5bfdb35b8d9492a77b20dac7eba025019d.37.1
  • Builder image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/gigl-base-images/gigl-builder:e7390e5bfdb35b8d9492a77b20dac7eba025019d.37.1

Updated dep_vars.env with new image names.
Updated .github/cloud_builder/run_command_on_pr_cloud_build.yaml with new builder image.

@svij-sc
Copy link
Collaborator Author

svij-sc commented Apr 23, 2025

/unit_test

@svij-sc
Copy link
Collaborator Author

svij-sc commented Apr 23, 2025

/integration_test

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

GiGL Automation

@ 22:27:21UTC : 🔄 Unit Test started.

@ 22:39:49UTC : ✅ Workflow completed successfully.

@svij-sc
Copy link
Collaborator Author

svij-sc commented Apr 23, 2025

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

GiGL Automation

@ 22:27:24UTC : 🔄 Integration Test started.

@ 23:18:24UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

GiGL Automation

@ 22:27:40UTC : 🔄 E2E Test started.

@ 24:08:20UTC : ✅ Workflow completed successfully.

@svij-sc svij-sc requested review from kmontemayor2-sc, nshah171 and zhao-tong and removed request for zhao-tong April 23, 2025 22:28
@svij-sc
Copy link
Collaborator Author

svij-sc commented Apr 23, 2025

/lint_test

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

GiGL Automation

@ 22:58:40UTC : 🔄 Lint Test started.

@ 23:05:33UTC : ❌ Workflow failed.
Please check the logs for more details.

@snap-research snap-research deleted a comment from github-actions bot Apr 23, 2025
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew this is a big one... I assume you've done your due diligence here and just did a cp so lgtm provided tests pass.

@svij-sc
Copy link
Collaborator Author

svij-sc commented Apr 24, 2025

/lint_test

@snap-research snap-research deleted a comment from github-actions bot Apr 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

GiGL Automation

@ 03:00:06UTC : 🔄 Lint Test started.

@ 03:09:47UTC : ✅ Workflow completed successfully.

@svij-sc svij-sc added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 26b4d32 Apr 24, 2025
4 checks passed
@svij-sc svij-sc deleted the svij/update-oss-release branch April 24, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants