Linux compilation error

[aaannestad]

Describe your bug here. And how to reproduce it.

I'm trying to compile this on Arch, and getting errors. So far, I've cloned the git repo and copied the ROM into ./zelda3.smc. Having done this, running make in the top-level zelda3 directory returns errors:

src/messaging.c: In function ‘RenderText_Draw_MessageCharacters’:
src/messaging.c:2394:5: error: too many arguments to function ‘VWF_RenderSingle’; expected 0, have 1
 2394 |     VWF_RenderSingle(TEXTCMD_PARAM(cmd));
      |     ^~~~~~~~~~~~~~~~
In file included from src/messaging.c:1:
src/messaging.h:110:6: note: declared here
  110 | void VWF_RenderSingle();
      |      ^~~~~~~~~~~~~~~~
src/messaging.c: At top level:
src/messaging.c:2512:6: error: conflicting types for ‘VWF_RenderSingle’; have ‘void(int)’
 2512 | void VWF_RenderSingle(int c) {  // 8ecab8
      |      ^~~~~~~~~~~~~~~~
src/messaging.h:110:6: note: previous declaration of ‘VWF_RenderSingle’ with type ‘void(void)’
  110 | void VWF_RenderSingle();
      |      ^~~~~~~~~~~~~~~~
make: *** [Makefile:23: src/messaging.o] Error 1

What's the solution here?

What is your build target?

Linux

[thenexus7]

I got the exact same error message. (Python 3.13.7 on Fedora 42)
SFC sha256 and dependencies checked twice.

Thanks all of you for your work :)

[dadadel]

@aaannestad @thenexus7

I have made these changes and it worked:

diff --git a/snes/snes.c b/snes/snes.c
index e52620c..29e0a3f 100644
--- a/snes/snes.c
+++ b/snes/snes.c
@@ -30,7 +30,7 @@ Snes* snes_init(uint8_t *ram) {
   snes->cpu = cpu_init(snes, 0);
   snes->apu = apu_init();
   snes->dma = dma_init(snes);
-  snes->ppu = ppu_init(snes);
+  snes->ppu = ppu_init();//snes);
   snes->cart = cart_init(snes);
   snes->input1 = input_init(snes);
   snes->input2 = input_init(snes);
diff --git a/src/messaging.h b/src/messaging.h
index 817e22c..385c9e8 100644
--- a/src/messaging.h
+++ b/src/messaging.h
@@ -107,7 +107,7 @@ void RenderText_Draw_BorderIncremental();
 void RenderText_Draw_CharacterTilemap();
 void RenderText_Draw_MessageCharacters();
 void RenderText_Draw_Finish();
-void VWF_RenderSingle();
+void VWF_RenderSingle(int c);
 void RenderText_Draw_Choose2LowOr3();
 void RenderText_Draw_ChooseItem();
 void RenderText_FindYItem_Previous();
diff --git a/src/zelda_rtl.c b/src/zelda_rtl.c
index 1c74116..c920d91 100644
--- a/src/zelda_rtl.c
+++ b/src/zelda_rtl.c
@@ -264,7 +264,7 @@ static void ZeldaRunGameLoop() {
 
 void ZeldaInitialize() {
   g_zenv.dma = dma_init(NULL);
-  g_zenv.ppu = ppu_init(NULL);
+  g_zenv.ppu = ppu_init();//NULL);
   g_zenv.ram = g_ram;
   g_zenv.sram = (uint8*)calloc(8192, 1);
   g_zenv.vram = g_zenv.ppu->vram;
@@ -887,4 +887,4 @@ void ZeldaWriteSram() {
   } else {
     fprintf(stderr, "Unable to write saves/sram.dat\n");
   }
}