[async] test fixes:

Fixed synch factory in async code of _wif.py
Fixed async make_session and added necessary host_port_pooling

Author: sfc-gh-fpawlowski

src/snowflake/connector/aio/_session_manager.py

@@ -541,17 +541,24 @@ def make_session(self, *, url: str | None = None) -> aiohttp.ClientSession:
             session_manager=self.clone(),
             snowflake_ocsp_mode=self._cfg.snowflake_ocsp_mode,
         )
-        # We use requests.utils here (in asynch code) to keep the behaviour uniform for synch and asynch code. If we wanted each version to depict its http library's behaviour, we could use here: aiohttp.helpers.proxy_bypass(url, proxies={...}) here
-        proxy = (
-            None
-            if should_bypass_proxies(url, no_proxy=self.config.no_proxy)
-            else self.proxy_url
-        )
+
+        proxy_from_conn_params: str | None = None
+        if not aiohttp.helpers.proxies_from_env():
+            # TODO: This is only needed because we want to keep compatibility with the synch driver version.
+            #   Otherwise, we could remove that condition and always pass proxy from conn params to the Session constructor.
+            #   But in such case precedence will be reverted and it will overwrite the env vars settings.
+
+            # We use requests.utils here (in asynch code) to keep the behaviour uniform for synch and asynch code. If we wanted each version to depict its http library's behaviour, we could use here: aiohttp.helpers.proxy_bypass(url, proxies={...}) here
+            proxy_from_conn_params = (
+                None
+                if should_bypass_proxies(url, no_proxy=self.config.no_proxy)
+                else self.proxy_url
+            )
         # Construct session with base proxy set, request() may override per-URL when bypassing
         return self.SessionWithProxy(
             connector=connector,
             trust_env=self._cfg.trust_env,
-            proxy=proxy,
+            proxy=proxy_from_conn_params,
         )
 
 

test/unit/aio/test_connection_async_unit.py

@@ -912,7 +912,7 @@ def test_connect_metadata_preservation():
         connect_doc == source_doc
     ), "inspect.getdoc(connect) should match inspect.getdoc(SnowflakeConnection.__init__)"
 
-    # Test 8: Check that connect is callable and returns expected type
+    # Test 8: Check that connect is callable
     assert callable(connect), "connect should be callable"
 
     # Test 9: Check type() and __class__ values (important for user introspection)
@@ -933,3 +933,4 @@ def test_connect_metadata_preservation():
     assert (
         len(params) > 0
     ), "connect should have parameters from SnowflakeConnection.__init__"
+    # Should have parameters like account, user, password, etc.

test/unit/aio/test_proxies_async.py

@@ -627,6 +627,8 @@ async def test_proxy_env_vars_take_precedence_over_connection_params(
     wiremock_generic_mappings_dir,
     proxy_env_vars,
     monkeypatch,
+    host_port_pooling,
+    fix_aiohttp_proxy_bypass,
 ):
     """Verify that proxy_host/proxy_port connection parameters take precedence over env vars.