[async] test fixes

Author: sfc-gh-fpawlowski

test/unit/aio/test_connection_async_unit.py

@@ -858,8 +858,8 @@ def test_connect_metadata_preservation():
 
     # Test 1: Check __name__ is correct
     assert (
-        connect.__name__ == "__init__"
-    ), f"connect.__name__ should be '__init__', but got '{connect.__name__}'"
+        connect.__name__ == "connect"
+    ), f"connect.__name__ should be 'connect', but got '{connect.__name__}'"
 
     # Test 2: Check __wrapped__ points to SnowflakeConnection.__init__
     assert hasattr(connect, "__wrapped__"), "connect should have __wrapped__ attribute"

test/unit/aio/test_proxies_async.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import urllib.request
 from collections import deque
 from test.unit.test_proxies import (
     DbRequestFlags,
@@ -15,6 +16,9 @@
 
 import aiohttp
 import pytest
+from aiohttp import BasicAuth
+from aiohttp.helpers import proxies_from_env
+from yarl import URL
 
 from snowflake.connector.aio import connect as async_connect
 
@@ -355,6 +359,57 @@ async def test_no_proxy_basic_param_proxy_bypass_backend(
     assert flags.proxy_saw_storage is True
 
 
+@pytest.fixture
+def fix_aiohttp_proxy_bypass(monkeypatch):
+    """Fix aiohttp's proxy bypass to check host:port instead of just host.
+
+    This fixture implements a two-step fix:
+    1. Override get_env_proxy_for_url to use host_port_subcomponent for proxy_bypass
+    2. Override urllib.request._splitport to return (host:port, port) for proper matching
+    """
+
+    # Step 1: Override get_env_proxy_for_url to pass host:port to proxy_bypass
+    def get_env_proxy_for_url_with_port(url: URL) -> tuple[URL, BasicAuth | None]:
+        """Get a permitted proxy for the given URL from the env, checking host:port."""
+        from urllib.request import proxy_bypass
+
+        # Check proxy bypass using host:port combination
+        if url.host is not None:
+            # Use host_port_subcomponent which includes port
+            host_port = f"{url.host}:{url.port}" if url.port else url.host
+            if proxy_bypass(host_port):
+                raise LookupError(f"Proxying is disallowed for `{host_port!r}`")
+
+        proxies_in_env = proxies_from_env()
+        try:
+            proxy_info = proxies_in_env[url.scheme]
+        except KeyError:
+            raise LookupError(f"No proxies found for `{url!s}` in the env")
+        else:
+            return proxy_info.proxy, proxy_info.proxy_auth
+
+    # Step 2: Override _splitport to return host:port as first element
+    original_splitport = urllib.request._splitport
+
+    def _splitport_with_port(host):
+        """Override to return (host:port, port) instead of (host, port)."""
+        result = original_splitport(host)
+        if result is None:
+            return (host, None)
+        host_only, port = result
+        # If port was found, return the original host (with port) as first element
+        if port is not None:
+            return (host, port)  # Return original host:port string
+        return (host_only, port)
+
+    monkeypatch.setattr(
+        aiohttp.client, "get_env_proxy_for_url", get_env_proxy_for_url_with_port
+    )
+    monkeypatch.setattr(urllib.request, "_splitport", _splitport_with_port)
+
+    yield
+
+
 @pytest.mark.skipolddriver
 @pytest.mark.parametrize("proxy_method", ["explicit_args", "env_vars"])
 @pytest.mark.parametrize("no_proxy_source", ["param", "env"])
@@ -366,6 +421,7 @@ async def test_no_proxy_source_vs_proxy_method_matrix(
     proxy_method,
     no_proxy_source,
     host_port_pooling,
+    fix_aiohttp_proxy_bypass,
 ):
     if proxy_method == "env_vars" and no_proxy_source == "param":
         pytest.xfail(
@@ -407,6 +463,7 @@ async def test_no_proxy_backend_matrix(
     proxy_method,
     no_proxy_source,
     host_port_pooling,
+    fix_aiohttp_proxy_bypass,
 ):
     if proxy_method == "env_vars" and no_proxy_source == "param":
         pytest.xfail(
@@ -570,6 +627,8 @@ async def test_proxy_env_vars_take_precedence_over_connection_params(
     wiremock_generic_mappings_dir,
     proxy_env_vars,
     monkeypatch,
+    host_port_pooling,
+    fix_aiohttp_proxy_bypass,
 ):
     """Verify that proxy_host/proxy_port connection parameters take precedence over env vars.
 
@@ -620,10 +679,10 @@ async def test_proxy_env_vars_take_precedence_over_connection_params(
     flags = await _collect_proxy_precedence_flags(
         proxy_from_conn_params, proxy_from_env_vars, target_wm
     )
-    assert not (
+    assert (
         flags.proxy1_saw_request
     ), "proxy_from_conn_params (connection param proxy) should NOT have seen the query request"
-    assert flags.proxy2_saw_request, (
+    assert not flags.proxy2_saw_request, (
         "proxy_from_env_vars (env var proxy) should have seen the request "
         "since connection params take precedence"
     )