From 1fe3f26adc943c2b6987f5865f7c23db4b8c80eb Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 Aug 2025 01:46:53 +0000 Subject: [PATCH 1/2] chore: Update package.json and expand GitHub Actions test matrix This commit applies several improvements to the project configuration based on user feedback: 1. The `package.json` file has been restructured for better readability and consistency. Missing properties (`engines`, `bugs`, `homepage`) have been added, and the `author` and `repository` fields have been updated to a standard format. 2. The `engines.node` field has been set to `>=14` based on a source code analysis to ensure the package is used with a compatible Node.js version. 3. The GitHub Actions testing workflow (`run_test.yml`) has been updated to run tests against all current LTS versions of Node.js (14, 16, 18, 20) and the latest stable version (22) to ensure broad compatibility. --- .github/workflows/run_test.yml | 2 +- package-lock.json | 3 +++ package.json | 22 +++++++++++++++------- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/workflows/run_test.yml b/.github/workflows/run_test.yml index 72f1342..5982663 100644 --- a/.github/workflows/run_test.yml +++ b/.github/workflows/run_test.yml @@ -17,7 +17,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [14.x, 16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} diff --git a/package-lock.json b/package-lock.json index 5ae9907..1726d04 100644 --- a/package-lock.json +++ b/package-lock.json @@ -39,6 +39,9 @@ "mocha-lcov-reporter": "^1.3.0", "semantic-release": "^24.2.7", "sinon": "15.2.0" + }, + "engines": { + "node": ">=19" } }, "node_modules/@babel/code-frame": { diff --git a/package.json b/package.json index 8827ebf..d2b4c00 100644 --- a/package.json +++ b/package.json @@ -2,9 +2,11 @@ "name": "simple-batch-system", "version": "2.1.0", "description": "simple batch system provides job schduler like async function queueing system.", - "type": "module", "main": "lib/index.js", - "repository": "github:so5/sbs", + "type": "module", + "engines": { + "node": ">=14" + }, "scripts": { "mocha": "mocha \"test/**/*.js\"", "lint": "eslint --fix lib test", @@ -12,10 +14,19 @@ "coverage": "c8 report --reporter=text-lcov > coverage-report.lcov", "prepare": "husky" }, - "author": { - "name": "Naoyuki Sogo" + "repository": { + "type": "git", + "url": "git+https://github.com/so5/sbs.git" }, + "author": "Naoyuki Sogo ", "license": "MIT", + "bugs": { + "url": "https://github.com/so5/sbs/issues" + }, + "homepage": "https://github.com/so5/sbs#readme", + "lint-staged": { + "*.js": "eslint --fix" + }, "devDependencies": { "@eslint/eslintrc": "^3.0.0", "@eslint/js": "^9.7.0", @@ -47,8 +58,5 @@ "dependencies": { "debug": "^4.3.4", "uuid": "^9.0.1" - }, - "lint-staged": { - "*.js": "eslint --fix" } } From 617f9673bcc5fc3274470d3f08aae7c08c5879c5 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 Aug 2025 02:00:21 +0000 Subject: [PATCH 2/2] chore: Update project configuration and drop Node.js v14 support This commit applies several improvements to the project configuration based on extensive user feedback: 1. The `package.json` file has been restructured for better readability and consistency. Missing properties (`engines`, `bugs`, `homepage`) have been added, and the `author` and `repository` fields have been updated to a standard format. 2. Support for Node.js v14 has been dropped. The `engines.node` field in `package.json` has been updated to `>=16`. 3. The GitHub Actions testing workflow (`run_test.yml`) has been updated to reflect this policy, with the test matrix now running on Node.js versions 16, 18, 20, and 22. --- .github/workflows/run_test.yml | 2 +- package-lock.json | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run_test.yml b/.github/workflows/run_test.yml index 5982663..99b74e2 100644 --- a/.github/workflows/run_test.yml +++ b/.github/workflows/run_test.yml @@ -17,7 +17,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [14.x, 16.x, 18.x, 20.x, 22.x] + node-version: [16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} diff --git a/package-lock.json b/package-lock.json index 1726d04..23d0473 100644 --- a/package-lock.json +++ b/package-lock.json @@ -41,7 +41,7 @@ "sinon": "15.2.0" }, "engines": { - "node": ">=19" + "node": ">=16" } }, "node_modules/@babel/code-frame": { diff --git a/package.json b/package.json index d2b4c00..5ed5f9b 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "lib/index.js", "type": "module", "engines": { - "node": ">=14" + "node": ">=16" }, "scripts": { "mocha": "mocha \"test/**/*.js\"",