Break up to separate elements

[deebloo]

Potentially break the twitter buttons up into separate elements. so etc. still keep them in one import but remove the need for the conditional dom.

[deebloo]

Example. To me this seems maybe a bit cleaner and easier to manage.
https://github.com/deebloo/twitter-button/blob/feature/separate-elements/src/twitter-button.html

[deebloo]

@Nevraeka what do you think? It would be a breaking change but technically so is updating to 0.9 :/

[Nevraeka]

As long as it handles its own dependency management ( as per the Golden Standard ) I don't see how it's a problem.

[deebloo]

I also tried it with vulcanize but do we want to pull in polymer with the element?

[deebloo]

@Nevraeka another branch that is using vulcanize. It creates two builds. One that includes Polymer in the build and one that requires you to import vulcanize on your own.
https://github.com/deebloo/twitter-button/tree/feature/vulcanize

[Nevraeka]

Hmmm... Not sure on this. I personally like elements pulling polymer in on their own. As far as vulcanize goes - what do you think of this @robdodson

[robdodson]

I think traditionally we don't vend vulcanized versions of components. If someone imports the vulcanized version of your component in their app, and it has already vulcanized in other imports which would have been deduped, then when they run vulcanize over their entire app they might get dependencies baked in twice. Sorry, if that's a confusing explanation. I think the short answer is, distribute the source and leave vulcanizing up to the user. And the source should always include imports for all of its dependencies.

[deebloo]

@robdodson totally makes sense. @Nevraeka we should look at it on Monday and decide the exact structure we want. Since they are all small we can just define all of them in a single file if we decide to go with separate elements. https://github.com/deebloo/twitter-button/blob/feature/separate-elements/src/twitter-button.html or we will do like Rob says and just include them all and leave vulcanization up to the user

[Nevraeka]

Thanks @robdodson . Definitely something we need to know. Thank you @deebloo . I'll follow up w/ you Monday