Skip to content

Commit fdc8906

Browse files
committed
Better order of operations in HTTP2::Connection#close.
1 parent 8523d4f commit fdc8906

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/async/http/protocol/http2/connection.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ def start_connection
6666
end
6767

6868
def close(error = nil)
69-
super
70-
7169
# Ensure the reader task is stopped.
7270
if @reader
7371
reader = @reader
7472
@reader = nil
7573
reader.stop
7674
end
75+
76+
super
7777
end
7878

7979
def read_in_background(parent: Task.current)
@@ -101,6 +101,8 @@ def read_in_background(parent: Task.current)
101101
ensure
102102
# Don't call #close twice.
103103
if @reader
104+
@reader = nil
105+
104106
self.close(error)
105107
end
106108
end

0 commit comments

Comments
 (0)