From 82c9f5fbf0a0bd9b8a898b5a70829b24b2f7e7cc Mon Sep 17 00:00:00 2001 From: Frederick Roy Date: Thu, 19 Feb 2026 18:46:13 +0900 Subject: [PATCH 1/2] Update CMakeLists.txt --- SofaImGui/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SofaImGui/CMakeLists.txt b/SofaImGui/CMakeLists.txt index d7e5c1368c..b917f99150 100644 --- a/SofaImGui/CMakeLists.txt +++ b/SofaImGui/CMakeLists.txt @@ -151,7 +151,7 @@ add_library(${PROJECT_NAME} SHARED ${HEADER_FILES} ${SOURCE_FILES} ${IMGUI_SOURC target_include_directories(${PROJECT_NAME} PUBLIC "$") target_link_libraries(${PROJECT_NAME} PUBLIC SofaGLFW Sofa.GL.Component.Rendering3D ${CMAKE_DL_LIBS}) target_link_libraries(${PROJECT_NAME} PRIVATE SimpleIni::SimpleIni) -if (EXISTS nfd) +if (TARGET nfd) target_link_libraries(${PROJECT_NAME} PRIVATE nfd) else() target_link_libraries(${PROJECT_NAME} PRIVATE nfd::nfd) From f7b87149a487752fe377d985ab62e7b4697fdc2a Mon Sep 17 00:00:00 2001 From: Olivier Roussel Date: Wed, 25 Feb 2026 15:51:45 +0100 Subject: [PATCH 2/2] create nfd::nfd alias if not defined --- SofaImGui/CMakeLists.txt | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/SofaImGui/CMakeLists.txt b/SofaImGui/CMakeLists.txt index b917f99150..05648bc589 100644 --- a/SofaImGui/CMakeLists.txt +++ b/SofaImGui/CMakeLists.txt @@ -40,7 +40,9 @@ elseif( (DEFINED SOFA_ALLOW_FETCH_DEPENDENCIES AND SOFA_ALLOW_FETCH_DEPENDENCIES ) set_property(TARGET nfd PROPERTY POSITION_INDEPENDENT_CODE ON) set_target_properties(nfd PROPERTIES LINKER_LANGUAGE CXX) - add_library(nfd::nfd ALIAS nfd) # introduced in nfd >= v1.2.1 +endif() +if(TARGET nfd AND NOT TARGET nfd::nfd) + add_library(nfd::nfd ALIAS nfd) # introduced in nfd >= v1.2.1 endif() # ImPlot @@ -151,11 +153,7 @@ add_library(${PROJECT_NAME} SHARED ${HEADER_FILES} ${SOURCE_FILES} ${IMGUI_SOURC target_include_directories(${PROJECT_NAME} PUBLIC "$") target_link_libraries(${PROJECT_NAME} PUBLIC SofaGLFW Sofa.GL.Component.Rendering3D ${CMAKE_DL_LIBS}) target_link_libraries(${PROJECT_NAME} PRIVATE SimpleIni::SimpleIni) -if (TARGET nfd) - target_link_libraries(${PROJECT_NAME} PRIVATE nfd) -else() - target_link_libraries(${PROJECT_NAME} PRIVATE nfd::nfd) -endif() +target_link_libraries(${PROJECT_NAME} PRIVATE nfd::nfd) # setup the same API exports for imgui target_compile_definitions(${PROJECT_NAME} PUBLIC IMGUI_API=SOFAIMGUI_API)