Refactor object storage credentials.

Author: Fernando Ojeda

SoftLayer/CLI/object_storage/credential/delete.py

@@ -9,7 +9,7 @@
 
 @click.command()
 @click.argument('identifier')
-@click.option('--credential_id', '-id', type=click.INT,
+@click.option('--credential_id', '-c', type=click.INT,
               help="This is the credential id associated with the volume")
 @environment.pass_env
 def cli(env, identifier, credential_id):
@@ -18,5 +18,4 @@ def cli(env, identifier, credential_id):
     mgr = SoftLayer.ObjectStorageManager(env.client)
     credential = mgr.delete_credential(identifier, credential_id=credential_id)
 
-    if credential:
-        env.fout("The credential was deleted successful")
+    env.fout(credential)

tests/CLI/modules/object_storage_tests.py

@@ -67,12 +67,10 @@ def test_delete_credential(self):
         accounts = self.set_mock('SoftLayer_Network_Storage_Hub_Cleversafe_Account', 'credentialDelete')
         accounts.return_value = True
 
-        result = self.run_command(['object-storage', 'credential', 'delete', '-id=100', '100'])
+        result = self.run_command(['object-storage', 'credential', 'delete', '-c=100', '100'])
 
         self.assert_no_fail(result)
-        self.assertEqual(json.loads(result.output),
-                         'The credential was deleted successful'
-                         )
+        self.assertEqual(json.loads(result.output), True)
 
     def test_limit_credential(self):
         accounts = self.set_mock('SoftLayer_Network_Storage_Hub_Cleversafe_Account', 'getCredentialLimit')

tests/managers/object_storage_tests.py

@@ -69,7 +69,7 @@ def test_delete_credential(self):
         accounts.return_value = 'The credential was deleted successful'
 
         credential = self.object_storage.delete_credential(100)
-        self.assertEqual(credential, 'The credential was deleted successful')
+        self.assertEqual(credential, True)
 
     def test_limit_credential(self):
         accounts = self.set_mock('SoftLayer_Network_Storage_Hub_Cleversafe_Account', 'getCredentialLimit')