exception when there is no prices was refactored

Author: acamacho82

SoftLayer/CLI/subnet/create.py

@@ -42,14 +42,10 @@ def cli(env, network, quantity, vlan_id, ipv6, test):
     if ipv6:
         version = 6
 
-    result = mgr.add_subnet(network,
-                            quantity=quantity,
-                            vlan_id=vlan_id,
-                            version=version,
-                            test_order=test)
-    if not result:
-        raise exceptions.CLIAbort(
-            'Unable to place order: No valid price IDs found.')
+    try:
+        result = mgr.add_subnet(network, quantity=quantity, vlan_id=vlan_id, version=version, test_order=test)
+    except SoftLayer.SoftLayerAPIError:
+        raise exceptions.CLIAbort('There is no price id for {} {} ipv{}'.format(quantity, network, version))
 
     table = formatting.Table(['Item', 'cost'])
     table.align['Item'] = 'r'

SoftLayer/managers/network.py

@@ -150,10 +150,6 @@ def add_subnet(self, subnet_type, quantity=None, vlan_id=None, version=4,
                 price_id = item['prices'][0]['id']
                 break
 
-        if not price_id:
-            raise TypeError('Invalid combination specified for ordering a'
-                            ' subnet.')
-
         order = {
             'packageId': 0,
             'prices': [{'id': price_id}],