Skip to content

Commit 39b3b2a

Browse files
author
caberos
committed
Fix to team code review comments
1 parent 66bc9ad commit 39b3b2a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

SoftLayer/CLI/firewall/detail.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ def cli(env, identifier):
1919
mgr = SoftLayer.FirewallManager(env.client)
2020

2121
firewall_type, firewall_id = firewall.parse_id(identifier)
22-
result = mgr.get_instance(firewall_id)
22+
_firewall = mgr.get_instance(firewall_id)
2323

2424
table = formatting.KeyValueTable(['name', 'value'])
2525
table.align['name'] = 'r'
2626
table.align['value'] = 'l'
2727

28-
table.add_row(['id', utils.lookup(result, 'id')])
29-
table.add_row(['primaryIpAddress', utils.lookup(result, 'primaryIpAddress')])
30-
table.add_row(['datacenter', utils.lookup(result, 'datacenter', 'longName')])
31-
table.add_row(['networkVlan', utils.lookup(result, 'networkVlan', 'name')])
32-
table.add_row(['networkVlaniD', utils.lookup(result, 'networkVlan', 'id')])
28+
table.add_row(['id', _firewall.get('id')])
29+
table.add_row(['primaryIpAddress', _firewall.get('primaryIpAddress')])
30+
table.add_row(['datacenter', utils.lookup(_firewall, 'datacenter', 'longName')])
31+
table.add_row(['networkVlan', utils.lookup(_firewall, 'networkVlan', 'name')])
32+
table.add_row(['networkVlaniD', utils.lookup(_firewall, 'networkVlan', 'id')])
3333

3434
if firewall_type == 'vlan':
3535
rules = mgr.get_dedicated_fwl_rules(firewall_id)

0 commit comments

Comments
 (0)