Skip to content

Commit 4592d73

Browse files
caberoscaberos
authored andcommitted
fix the team code review comments
1 parent e9752a8 commit 4592d73

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

SoftLayer/CLI/formatting.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -400,18 +400,9 @@ def _format_dict(result):
400400
table.align['value'] = 'l'
401401

402402
for key, value in result.items():
403+
value = iter_to_table(value)
404+
table.add_row([key, value])
403405

404-
table_list = Table(['value'])
405-
if str(value) == "[[], [], []]":
406-
for item in value:
407-
if str(item) == '[]':
408-
table_list.add_row(['empty'])
409-
else:
410-
table_list.add_row(item)
411-
table.add_row([key, table_list])
412-
else:
413-
value = iter_to_table(value)
414-
table.add_row([key, value])
415406
return table
416407

417408

@@ -420,13 +411,14 @@ def _format_list(result):
420411

421412
if not result:
422413
return result
423-
414+
table = Table(['value'])
424415
new_result = [item for item in result if item]
425-
416+
if len(new_result) == 0:
417+
table.add_row(["-"])
418+
return table
426419
if isinstance(new_result[0], dict):
427420
return _format_list_objects(new_result)
428421

429-
table = Table(['value'])
430422
for item in new_result:
431423
table.add_row([iter_to_table(item)])
432424
return table

0 commit comments

Comments
 (0)