More unittests were added to increase the coverage, an else conditional was removed since it will never be executed

Author: acamacho82

SoftLayer/CLI/dns/record_add.py

@@ -75,19 +75,16 @@ def cli(env, record, type, data, zone, ttl, priority, protocol, port, service, w
         zone_id = helpers.resolve_id(manager.resolve_ids, zone, name='zone')
 
         if type == 'MX':
-            result = manager.create_record_mx(zone_id, record, data, ttl=ttl, priority=priority)
+            manager.create_record_mx(zone_id, record, data, ttl=ttl, priority=priority)
         elif type == 'SRV':
-            result = manager.create_record_srv(zone_id, record, data, protocol, port, service,
-                                               ttl=ttl, priority=priority, weight=weight)
+            manager.create_record_srv(zone_id, record, data, protocol, port, service,
+                                      ttl=ttl, priority=priority, weight=weight)
         else:
-            result = manager.create_record(zone_id, record, type, data, ttl=ttl)
+            manager.create_record(zone_id, record, type, data, ttl=ttl)
 
     elif type == 'PTR':
-        result = manager.create_record_ptr(record, data, ttl=ttl)
+        manager.create_record_ptr(record, data, ttl=ttl)
     else:
         raise exceptions.CLIAbort("%s isn't a valid record type or zone is missing" % (type))
 
-    if result:
-        click.secho("%s record added successfully" % (type), fg='green')
-    else:
-        click.secho("Failed to add %s record" % (type), fg='red')
+    click.secho("%s record added successfully" % (type), fg='green')

tests/CLI/modules/dns_tests.py

@@ -78,6 +78,36 @@ def test_add_record(self):
         self.assert_no_fail(result)
         self.assertEqual(str(result.output), 'A record added successfully\n')
 
+    def test_add_record_mx(self):
+        result = self.run_command(['dns', 'record-add', 'hostname', 'MX',
+                                   'data', '--zone=1234', '--ttl=100', '--priority=25'])
+
+        self.assert_no_fail(result)
+        self.assertEqual(str(result.output), 'MX record added successfully\n')
+
+    def test_add_record_srv(self):
+        result = self.run_command(['dns', 'record-add', 'hostname', 'SRV',
+                                   'data', '--zone=1234', '--protocol=udp',
+                                   '--port=88', '--ttl=100', '--weight=5'])
+
+        self.assert_no_fail(result)
+        self.assertEqual(str(result.output), 'SRV record added successfully\n')
+
+    def test_add_record_ptr(self):
+        result = self.run_command(['dns', 'record-add', '192.168.1.1', 'PTR',
+                                   'hostname', '--ttl=100'])
+
+        self.assert_no_fail(result)
+        self.assertEqual(str(result.output), 'PTR record added successfully\n')
+
+    def test_add_record_abort(self):
+        result = self.run_command(['dns', 'record-add', 'hostname', 'A',
+                                   'data', '--ttl=100'])
+
+        self.assertEqual(result.exit_code, 2)
+        self.assertIsInstance(result.exception, exceptions.CLIAbort)
+        self.assertEqual(result.exception.message, "A isn't a valid record type or zone is missing")
+
     @mock.patch('SoftLayer.CLI.formatting.no_going_back')
     def test_delete_record(self, no_going_back_mock):
         no_going_back_mock.return_value = True