issue#1210 - Adding doc notes describing ISCSI Isolation must be enabled for new commands to work.

Author: oarosale

SoftLayer/CLI/block/subnets/assign.py

@@ -15,23 +15,23 @@ def cli(env, access_id, subnet_id):
     """Assign block storage subnets to the given host id.
 
     access_id is the host_id obtained by: slcli block access-list <volume_id>
+
+    SoftLayer_Account::iscsiisolationdisabled must be False to use this command
     """
     try:
         subnet_ids = list(subnet_id)
         block_manager = SoftLayer.BlockStorageManager(env.client)
         assigned_subnets = block_manager.assign_subnets_to_acl(access_id, subnet_ids)
 
         for subnet in assigned_subnets:
-            message = "{0}".format("Successfully assigned subnet id: " + str(subnet) +
-                                   ' to allowed host id: ' + str(access_id) + '.')
+            message = "Successfully assigned subnet id: {} to allowed host id: {}".format(subnet, access_id)
             click.echo(message)
 
         failed_to_assign_subnets = list(set(subnet_ids) - set(assigned_subnets))
         for subnet in failed_to_assign_subnets:
-            message = "{0}".format("Failed to assign subnet id: " + str(subnet) +
-                                   ' to allowed host id: ' + str(access_id) + '.')
+            message = "Failed to assign subnet id: {} to allowed host id: {}".format(subnet, access_id)
             click.echo(message)
 
     except SoftLayer.SoftLayerAPIError as ex:
-        message = "{0}".format("Unable to assign subnets.\nReason: " + ex.faultString)
+        message = "Unable to assign subnets.\nReason: {}".format(ex.faultString)
         click.echo(message)

SoftLayer/CLI/block/subnets/list.py

@@ -39,6 +39,5 @@ def cli(env, access_id):
         env.fout(table)
 
     except SoftLayer.SoftLayerAPIError as ex:
-        message = "{0}".format("Unable to list assigned subnets for access-id: " +
-                               str(access_id) + ".\nReason: " + ex.faultString)
+        message = "Unable to list assigned subnets for access-id: {}.\nReason: {}".format(access_id, ex.faultString)
         click.echo(message)

SoftLayer/CLI/block/subnets/remove.py

@@ -15,23 +15,23 @@ def cli(env, access_id, subnet_id):
     """Remove block storage subnets for the given host id.
 
     access_id is the host_id obtained by: slcli block access-list <volume_id>
+
+    SoftLayer_Account::iscsiisolationdisabled must be False to use this command
     """
     try:
         subnet_ids = list(subnet_id)
         block_manager = SoftLayer.BlockStorageManager(env.client)
         removed_subnets = block_manager.remove_subnets_from_acl(access_id, subnet_ids)
 
         for subnet in removed_subnets:
-            message = "{0}".format("Successfully removed subnet id: " + str(subnet) +
-                                   ' for allowed host id: ' + str(access_id) + '.')
+            message = "Successfully removed subnet id: {} for allowed host id: {}".format(subnet, access_id)
             click.echo(message)
 
         failed_to_remove_subnets = list(set(subnet_ids) - set(removed_subnets))
         for subnet in failed_to_remove_subnets:
-            message = "{0}".format("Failed to remove subnet id: " + str(subnet) +
-                                   ' for allowed host id: ' + str(access_id) + '.')
+            message = "Failed to remove subnet id: {} for allowed host id: {}".format(subnet, access_id)
             click.echo(message)
 
     except SoftLayer.SoftLayerAPIError as ex:
-        message = "{0}".format("Unable to remove subnets.\nReason: " + ex.faultString)
+        message = "Unable to remove subnets.\nReason: {}".format(ex.faultString)
         click.echo(message)