Skip to content

Commit 5e61352

Browse files
committed
adding a default value to dictionaries
1 parent eed15b0 commit 5e61352

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

SoftLayer/CLI/autoscale/detail.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def cli(env, identifier):
3434
table.add_row(['Cooldown', "{} seconds".format(group.get('cooldown'))])
3535
table.add_row(['Last Action', utils.clean_time(group.get('lastActionDate'))])
3636

37-
for network in group.get('networkVlans'):
37+
for network in group.get('networkVlans', []):
3838
network_type = utils.lookup(network, 'networkVlan', 'networkSpace')
3939
router = utils.lookup(network, 'networkVlan', 'primaryRouter', 'hostname')
4040
vlan_number = utils.lookup(network, 'networkVlan', 'vlanNumber')
@@ -55,17 +55,16 @@ def cli(env, identifier):
5555
config_table.add_row(['Core', template.get('startCpus')])
5656
config_table.add_row(['Ram', template.get('maxMemory')])
5757
network = template.get('networkComponents')
58-
config_table.add_row(['Network', network[0]['maxSpeed']])
58+
config_table.add_row(['Network', network[0]['maxSpeed'] if network else 'Default'])
5959
ssh_keys = template.get('sshKeys', [])
6060
ssh_manager = SoftLayer.SshKeyManager(env.client)
6161
for key in ssh_keys:
6262
# Label isn't included when retrieved from the AutoScale group...
6363
ssh_key = ssh_manager.get_key(key.get('id'))
6464
config_table.add_row(['SSH Key {}'.format(ssh_key.get('id')), ssh_key.get('label')])
65-
disks = template.get('blockDevices')
66-
disk_type = "SAN"
67-
if template.get('localDiskFlag'):
68-
disk_type = "Local"
65+
disks = template.get('blockDevices', [])
66+
disk_type = "Local" if template.get('localDiskFlag') else "SAN"
67+
6968
for disk in disks:
7069
disk_image = disk.get('diskImage')
7170
config_table.add_row(['{} Disk {}'.format(disk_type, disk.get('device')), disk_image.get('capacity')])
@@ -76,15 +75,15 @@ def cli(env, identifier):
7675

7776
# Policy Config Table
7877
policy_table = formatting.KeyValueTable(["Policy", "Cooldown"])
79-
policies = group.get('policies')
78+
policies = group.get('policies', [])
8079
for policy in policies:
8180
policy_table.add_row([policy.get('name'), policy.get('cooldown') or group.get('cooldown')])
8281

8382
env.fout(policy_table)
8483

8584
# Active Guests
8685
member_table = formatting.Table(['Id', 'Hostname', 'Created'], title="Active Guests")
87-
guests = group.get('virtualGuestMembers')
86+
guests = group.get('virtualGuestMembers', [])
8887
for guest in guests:
8988
real_guest = guest.get('virtualGuest')
9089
member_table.add_row([

0 commit comments

Comments
 (0)