Merge pull request #1460 from allmightyspiff/issues1436

Fixes shift+ins when pasteing into a password field for windows users.

Author: allmightyspiff

SoftLayer/CLI/environment.py

@@ -67,7 +67,23 @@ def input(self, prompt, default=None, show_default=True):
 
     def getpass(self, prompt, default=None):
         """Provide a password prompt."""
-        return click.prompt(prompt, hide_input=True, default=default)
+        password = click.prompt(prompt, hide_input=True, default=default)
+
+        # https://github.com/softlayer/softlayer-python/issues/1436
+        # click.prompt uses python's getpass() in the background
+        # https://github.com/python/cpython/blob/3.9/Lib/getpass.py#L97
+        # In windows, shift+insert actually inputs the below 2 characters
+        # If we detect those 2 characters, need to manually read from the clipbaord instead
+        # https://stackoverflow.com/questions/101128/how-do-i-read-text-from-the-clipboard
+        if password == 'àR':
+            # tkinter is a built in python gui, but it has clipboard reading functions.
+            # pylint: disable=import-outside-toplevel
+            from tkinter import Tk
+            tk_manager = Tk()
+            password = tk_manager.clipboard_get()
+            # keep the window from showing
+            tk_manager.withdraw()
+        return password
 
     # Command loading methods
     def list_commands(self, *path):

tests/CLI/environment_tests.py

@@ -7,6 +7,7 @@
 
 import click
 import mock
+# from unittest.mock import MagicMock
 
 from SoftLayer.CLI import environment
 from SoftLayer import testing
@@ -55,6 +56,14 @@ def test_getpass(self, prompt_mock):
         prompt_mock.assert_called_with('input', default=None, hide_input=True)
         self.assertEqual(prompt_mock(), r)
 
+    @mock.patch('click.prompt')
+    @mock.patch('tkinter.Tk')
+    def test_getpass_issues1436(self, tk, prompt_mock):
+        prompt_mock.return_value = 'àR'
+        self.env.getpass('input')
+        prompt_mock.assert_called_with('input', default=None, hide_input=True)
+        tk.assert_called_with()
+
     def test_resolve_alias(self):
         self.env.aliases = {'aliasname': 'realname'}
         r = self.env.resolve_alias('aliasname')