Skip to content

Commit 75a7fc0

Browse files
author
Sergio Carlos Morales Angeles
committed
Allow ordering of account restricted presets
1 parent 4ec8756 commit 75a7fc0

File tree

4 files changed

+36
-15
lines changed

4 files changed

+36
-15
lines changed

SoftLayer/fixtures/SoftLayer_Product_Package.py

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -666,15 +666,27 @@
666666
]
667667
}
668668

669+
activePreset1 = {
670+
'description': 'Single Xeon 1270, 8GB Ram, 2x1TB SATA disks, Non-RAID',
671+
'id': 64,
672+
'isActive': '1',
673+
'keyName': 'S1270_8GB_2X1TBSATA_NORAID',
674+
'name': 'S1270 8GB 2X1TBSATA NORAID',
675+
'packageId': 200
676+
}
677+
678+
activePreset2 = {
679+
'description': 'Dual Xeon Gold, 384GB Ram, 4x960GB SSD, RAID 10',
680+
'id': 65,
681+
'isActive': '1',
682+
'keyName': 'DGOLD_6140_384GB_4X960GB_SSD_SED_RAID_10',
683+
'name': 'DGOLD 6140 384GB 4X960GB SSD SED RAID 10',
684+
'packageId': 200
685+
}
686+
669687
getAllObjects = [{
670-
'activePresets': [{
671-
'description': 'Single Xeon 1270, 8GB Ram, 2x1TB SATA disks, Non-RAID',
672-
'id': 64,
673-
'isActive': '1',
674-
'keyName': 'S1270_8GB_2X1TBSATA_NORAID',
675-
'name': 'S1270 8GB 2X1TBSATA NORAID',
676-
'packageId': 200
677-
}],
688+
'activePresets': [activePreset1],
689+
'accountRestrictedActivePresets': [activePreset2],
678690
'description': 'Bare Metal Server',
679691
'firstOrderStepId': 1,
680692
'id': 200,

SoftLayer/managers/hardware.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def get_create_options(self):
359359

360360
# Sizes
361361
sizes = []
362-
for preset in package['activePresets']:
362+
for preset in package['activePresets'] + package['accountRestrictedActivePresets']:
363363
sizes.append({
364364
'name': preset['description'],
365365
'key': preset['keyName']
@@ -418,6 +418,7 @@ def _get_package(self):
418418
prices
419419
],
420420
activePresets,
421+
accountRestrictedActivePresets,
421422
regions[location[location[priceGroups]]]
422423
'''
423424

@@ -774,7 +775,7 @@ def _get_location(package, location):
774775

775776
def _get_preset_id(package, size):
776777
"""Get the preset id given the keyName of the preset."""
777-
for preset in package['activePresets']:
778+
for preset in package['activePresets'] + package['accountRestrictedActivePresets']:
778779
if preset['keyName'] == size or preset['id'] == size:
779780
return preset['id']
780781

tests/CLI/modules/server_tests.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,9 @@ def test_create_options(self):
264264
expected = [
265265
[{'datacenter': 'Washington 1', 'value': 'wdc01'}],
266266
[{'size': 'Single Xeon 1270, 8GB Ram, 2x1TB SATA disks, Non-RAID',
267-
'value': 'S1270_8GB_2X1TBSATA_NORAID'}],
267+
'value': 'S1270_8GB_2X1TBSATA_NORAID'},
268+
{'size': 'Dual Xeon Gold, 384GB Ram, 4x960GB SSD, RAID 10',
269+
'value': 'DGOLD_6140_384GB_4X960GB_SSD_SED_RAID_10'}],
268270
[{'operating_system': 'Ubuntu / 14.04-64',
269271
'value': 'UBUNTU_14_64'}],
270272
[{'port_speed': '10 Mbps Public & Private Network Uplinks',

tests/managers/hardware_tests.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,16 @@ def test_get_create_options(self):
126126
'key': '10',
127127
'name': '10 Mbps Public & Private Network Uplinks'
128128
}],
129-
'sizes': [{
130-
'key': 'S1270_8GB_2X1TBSATA_NORAID',
131-
'name': 'Single Xeon 1270, 8GB Ram, 2x1TB SATA disks, Non-RAID'
132-
}]
129+
'sizes': [
130+
{
131+
'key': 'S1270_8GB_2X1TBSATA_NORAID',
132+
'name': 'Single Xeon 1270, 8GB Ram, 2x1TB SATA disks, Non-RAID'
133+
},
134+
{
135+
'key': 'DGOLD_6140_384GB_4X960GB_SSD_SED_RAID_10',
136+
'name': 'Dual Xeon Gold, 384GB Ram, 4x960GB SSD, RAID 10'
137+
}
138+
]
133139
}
134140

135141
self.assertEqual(options, expected)

0 commit comments

Comments
 (0)