Remove default filter on subnet list and fix the subnet detail

Author: caberos

SoftLayer/CLI/subnet/detail.py

@@ -38,7 +38,7 @@ def cli(env, identifier, no_vs, no_hardware):
     table.add_row(['identifier',
                    '%s/%s' % (subnet['networkIdentifier'],
                               str(subnet['cidr']))])
-    table.add_row(['subnet type', subnet['subnetType']])
+    table.add_row(['subnet type', subnet.get('subnetType', formatting.blank())])
     table.add_row(['network space',
                    utils.lookup(subnet, 'networkVlan', 'networkSpace')])
     table.add_row(['gateway', subnet.get('gateway', formatting.blank())])

SoftLayer/managers/network.py

@@ -491,26 +491,6 @@ def list_subnets(self, identifier=None, datacenter=None, version=0,
         if 'mask' not in kwargs:
             kwargs['mask'] = DEFAULT_SUBNET_MASK
 
-        _filter = utils.NestedDict(kwargs.get('filter') or {})
-
-        if identifier:
-            _filter['subnets']['networkIdentifier'] = (
-                utils.query_filter(identifier))
-        if datacenter:
-            _filter['subnets']['datacenter']['name'] = (
-                utils.query_filter(datacenter))
-        if version:
-            _filter['subnets']['version'] = utils.query_filter(version)
-        if subnet_type:
-            _filter['subnets']['subnetType'] = utils.query_filter(subnet_type)
-        else:
-            # This filters out global IPs from the subnet listing.
-            _filter['subnets']['subnetType'] = {'operation': '!= GLOBAL_IP'}
-        if network_space:
-            _filter['subnets']['networkVlan']['networkSpace'] = (
-                utils.query_filter(network_space))
-
-        kwargs['filter'] = _filter.to_dict()
         kwargs['iter'] = True
         return self.client.call('Account', 'getSubnets', **kwargs)