Merge branch 'caberos-issue1993'

Author: allmightyspiff

SoftLayer/CLI/image/list.py

@@ -14,19 +14,23 @@
 @click.option('--name', default=None, help='Filter on image name')
 @click.option('--public/--private', is_flag=True, default=None,
               help='Display only public or private images')
+@click.option('--limit', '-l',
+              help='How many results to get in one api call',
+              default=100,
+              show_default=True)
 @environment.pass_env
-def cli(env, name, public):
+def cli(env, name, public, limit):
     """List images."""
 
     image_mgr = SoftLayer.ImageManager(env.client)
 
     images = []
     if public in [False, None]:
-        for image in image_mgr.list_private_images(name=name, mask=image_mod.MASK):
+        for image in image_mgr.list_private_images(name=name, limit=limit, mask=image_mod.MASK):
             images.append(image)
 
     if public in [True, None]:
-        for image in image_mgr.list_public_images(name=name, mask=image_mod.MASK):
+        for image in image_mgr.list_public_images(name=name, limit=limit, mask=image_mod.MASK):
             images.append(image)
 
     table = formatting.Table(['Id', 'Name', 'Type', 'Visibility', 'Account', 'OS', 'Created', 'Notes'])

SoftLayer/managers/image.py

@@ -46,7 +46,7 @@ def delete_image(self, image_id):
         """
         self.vgbdtg.deleteObject(id=image_id)
 
-    def list_private_images(self, guid=None, name=None, **kwargs):
+    def list_private_images(self, guid=None, name=None, limit=100, **kwargs):
         """List all private images.
 
         :param string guid: filter based on GUID
@@ -67,8 +67,8 @@ def list_private_images(self, guid=None, name=None, **kwargs):
 
         kwargs['filter'] = _filter.to_dict()
 
-        account = self.client['Account']
-        return account.getPrivateBlockDeviceTemplateGroups(**kwargs)
+        return self.client.iter_call('SoftLayer_Account', 'getPrivateBlockDeviceTemplateGroups',
+                                     filter=kwargs['filter'], mask=kwargs['mask'], limit=limit)
 
     def list_public_images(self, guid=None, name=None, limit=100, **kwargs):
         """List all public images.
@@ -89,7 +89,8 @@ def list_public_images(self, guid=None, name=None, limit=100, **kwargs):
 
         kwargs['filter'] = _filter.to_dict()
 
-        return self.vgbdtg.getPublicImages(**kwargs, limit=limit)
+        return self.client.iter_call('SoftLayer_Virtual_Guest_Block_Device_Template_Group', 'getPublicImages',
+                                     filter=kwargs['filter'], mask=kwargs['mask'], limit=limit)
 
     def _get_ids_from_name_public(self, name):
         """Get public images which match the given name."""

tests/managers/image_tests.py

@@ -33,45 +33,41 @@ def test_delete_image(self):
         self.assert_called_with(IMAGE_SERVICE, 'deleteObject', identifier=100)
 
     def test_list_private_images(self):
-        results = self.image.list_private_images()
-
+        # Casting to list() to force the iter_call generator to run
+        results = list(self.image.list_private_images())
         self.assertEqual(len(results), 2)
-        self.assert_called_with('SoftLayer_Account',
-                                'getPrivateBlockDeviceTemplateGroups')
+        self.assert_called_with('SoftLayer_Account', 'getPrivateBlockDeviceTemplateGroups')
 
     def test_list_private_images_with_filters(self):
-        results = self.image.list_private_images(
-            guid='0FA9ECBD-CF7E-4A1F-1E36F8D27C2B', name='name')
+        # Casting to list() to force the iter_call generator to run
+        results = list(self.image.list_private_images(guid='0FA9ECBD-CF7E-4A1F-1E36F8D27C2B', name='name'))
 
-        self.assertEqual(len(results), 2)
         _filter = {
             'privateBlockDeviceTemplateGroups': {
                 'globalIdentifier': {
                     'operation': '_= 0FA9ECBD-CF7E-4A1F-1E36F8D27C2B'},
                 'name': {'operation': '_= name'}}
         }
-        self.assert_called_with('SoftLayer_Account',
-                                'getPrivateBlockDeviceTemplateGroups',
-                                filter=_filter)
+        self.assertEqual(len(results), 2)
+        self.assert_called_with('SoftLayer_Account', 'getPrivateBlockDeviceTemplateGroups', filter=_filter)
 
     def test_list_public_images(self):
-        results = self.image.list_public_images()
-
+        # Casting to list() to force the iter_call generator to run
+        results = list(self.image.list_public_images())
         self.assertEqual(len(results), 2)
         self.assert_called_with(IMAGE_SERVICE, 'getPublicImages')
 
     def test_list_public_images_with_filters(self):
-        results = self.image.list_public_images(
-            guid='0FA9ECBD-CF7E-4A1F-1E36F8D27C2B', name='name')
-
+        # Casting to list() to force the iter_call generator to run
+        results = list(self.image.list_public_images(guid='0FA9ECBD-CF7E-4A1F-1E36F8D27C2B', name='name'))
+        self.assertEqual(len(results), 2)
         _filter = {
             'globalIdentifier': {
                 'operation': '_= 0FA9ECBD-CF7E-4A1F-1E36F8D27C2B'},
             'name': {'operation': '_= name'}
         }
-        self.assertEqual(len(results), 2)
-        self.assert_called_with(IMAGE_SERVICE, 'getPublicImages',
-                                filter=_filter)
+
+        self.assert_called_with(IMAGE_SERVICE, 'getPublicImages', filter=_filter)
 
     def test_resolve_ids_guid(self):
         result = self.image.resolve_ids('3C1F3C68-0B67-4F5E-8907-D0FC84BF3F12')