fix Christopher code review comments

Author: caberos

SoftLayer/CLI/account/orders.py

@@ -20,10 +20,9 @@ def cli(env, limit):
     manager = AccountManager(env.client)
     orders = manager.get_account_all_billing_orders(limit)
 
-    table = []
-    order_table = formatting.Table(['id', 'State', 'user', 'PurchaseDate', 'orderTotalAmount', 'Items'],
+    order_table = formatting.Table(['Id', 'State', 'User', 'Date', 'Amount', 'Item'],
                                    title="orders")
-    order_table.sortby = 'orderTotalAmount'
+    order_table.sortby = 'Amount'
     order_table.align = 'l'
 
     for order in orders:
@@ -34,5 +33,4 @@ def cli(env, limit):
 
         order_table.add_row([order['id'], order['status'], order['userRecord']['username'], create_date,
                              order['orderTotalAmount'], utils.trim_to(' '.join(map(str, items)), 50)])
-    table.append(order_table)
-    env.fout(formatting.listing(table, separator='\n'))
+    env.fout(order_table)

SoftLayer/managers/account.py

@@ -234,7 +234,7 @@ def cancel_item(self, identifier, reason="No longer needed", note=None):
 
         return self.client.call('Billing_Item', 'cancelItem', False, True, reason, note, id=identifier)
 
-    def get_account_all_billing_orders(self, limit, mask=None):
+    def get_account_all_billing_orders(self, limit=100, mask=None):
         """Gets all the topLevelBillingItems currently active on the account
 
         :param string mask: Object Mask
@@ -247,14 +247,6 @@ def get_account_all_billing_orders(self, limit, mask=None):
                   initialInvoice[id,amount,invoiceTotalAmount],
                   items[description]
                """
-        object_filter = {
-            'createDate': {
-                'operation': 'orderBy',
-                'options': [{
-                    'name': 'sort',
-                    'value': ['DESC']
-                }]}
-            }
-
+        print(limit)
         return self.client.call('Billing_Order', 'getAllObjects',
-                                limit=limit, mask=mask, filter=object_filter)
+                                limit=limit, mask=mask)