Solved comments

Author: edsonarios

SoftLayer/managers/account.py

@@ -53,7 +53,7 @@ def get_summary(self):
         """
         return self.client.call('Account', 'getObject', mask=mask)
 
-    def get_upcoming_events(self, event_type, date_min):
+    def get_upcoming_events(self, event_type, date_min=None):
         """Retrieves a list of Notification_Occurrence_Events that have not ended yet
 
         :param: String event_type: notification event type.
@@ -76,7 +76,7 @@ def get_upcoming_events(self, event_type, date_min):
         return self.client.call('Notification_Occurrence_Event', 'getAllObjects', filter=_filter, mask=mask, iter=True)
 
     @staticmethod
-    def add_event_filter(_filter, event_type, date_min):
+    def add_event_filter(_filter, event_type, date_min=None):
         """Add data to the object filter.
 
         :param: _filter: event filter.

tests/managers/account_tests.py

@@ -21,15 +21,15 @@ def test_get_summary(self):
         self.assert_called_with('SoftLayer_Account', 'getObject')
 
     def test_get_planned_upcoming_events(self):
-        self.manager.get_upcoming_events("PLANNED", "")
+        self.manager.get_upcoming_events("PLANNED")
         self.assert_called_with(self.SLNOE, 'getAllObjects')
 
     def test_get_unplanned_upcoming_events(self):
-        self.manager.get_upcoming_events("UNPLANNED_INCIDENT", "")
+        self.manager.get_upcoming_events("UNPLANNED_INCIDENT")
         self.assert_called_with(self.SLNOE, 'getAllObjects')
 
     def test_get_announcement_upcoming_events(self):
-        self.manager.get_upcoming_events("ANNOUNCEMENT", "")
+        self.manager.get_upcoming_events("ANNOUNCEMENT")
         self.assert_called_with(self.SLNOE, 'getAllObjects')
 
     def test_add_planned_event_filter(self):
@@ -41,7 +41,7 @@ def test_add_planned_event_filter(self):
                 }
             }
         }
-        self.manager.add_event_filter(_filter, event_type, "")
+        self.manager.add_event_filter(_filter, event_type)
 
     def test_add_unplanned_event_filter(self):
         event_type = 'UNPLANNED_INCIDENT'
@@ -52,7 +52,7 @@ def test_add_unplanned_event_filter(self):
                 }
             }
         }
-        self.manager.add_event_filter(_filter, event_type, "")
+        self.manager.add_event_filter(_filter, event_type)
 
     def test_add_announcement_event_filter(self):
         event_type = 'ANNOUNCEMENT'
@@ -63,7 +63,7 @@ def test_add_announcement_event_filter(self):
                 }
             }
         }
-        self.manager.add_event_filter(_filter, event_type, "")
+        self.manager.add_event_filter(_filter, event_type)
 
     def test_ack_event(self):
         self.manager.ack_event(12345)