fixed some anaylsis complaints

Author: allmightyspiff

SoftLayer/fixtures/SoftLayer_Location.py

@@ -9,4 +9,4 @@
         "longName": "San Jose 1",
         "name": "sjc01"
     }]
-getDatacenters = [{'id': 1854895, 'name': 'dal13', 'regions': [{'keyname': 'DALLAS13'}]}]
+getDatacenters = [{'id': 1854895, 'name': 'dal13', 'regions': [{'keyname': 'DALLAS13'}]}]

SoftLayer/managers/ordering.py

@@ -484,12 +484,11 @@ def get_location_id(self, location):
 
         mask = "mask[id,name,regions[keyname]]"
         if match(r'[a-zA-Z]{3}[0-9]{2}', location) is not None:
-            search = {'name' : {'operation': location}}
+            search = {'name': {'operation': location}}
         else:
-            search = {'regions' : {'keyname' : {'operation': location}}}
+            search = {'regions': {'keyname': {'operation': location}}}
         datacenter = self.client.call('SoftLayer_Location', 'getDatacenters', mask=mask, filter=search)
         # [{'id': 1854895, 'name': 'dal13', 'regions': [{'keyname': 'DALLAS13'}]}]
         if len(datacenter) != 1:
             raise exceptions.SoftLayerError("Unable to find location: %s" % location)
         return datacenter[0]['id']
-

tests/managers/ordering_tests.py

@@ -383,12 +383,11 @@ def test_get_location_id_short(self):
 
     def test_get_location_id_keyname(self):
         locations = self.set_mock('SoftLayer_Location', 'getDatacenters')
-        locations.return_value =[{'id': 1854895, 'name': 'dal13', 'regions': [{'keyname': 'DALLAS13'}]}]
+        locations.return_value = [{'id': 1854895, 'name': 'dal13', 'regions': [{'keyname': 'DALLAS13'}]}]
         dc_id = self.ordering.get_location_id('DALLAS13')
         self.assertEqual(1854895, dc_id)
 
     def test_get_location_id_exception(self):
         locations = self.set_mock('SoftLayer_Location', 'getDatacenters')
         locations.return_value = []
         self.assertRaises(exceptions.SoftLayerError,  self.ordering.get_location_id, "BURMUDA")
-