Edit autoscale groups command

Author: allmightyspiff

SoftLayer/CLI/autoscale/edit.py

@@ -9,19 +9,49 @@
 
 @click.command()
 @click.argument('identifier')
-# Suspend / Unsuspend
-# Name
-# Min/Max
-# template->userData
-# 'hostname', 'domain', 'startCpus', 'maxMemory', 'localDiskFlag'
-# 'blockDeviceTemplateGroup.globalIdentifier
-# blockDevices.diskImage.capacity
-# sshKeys.id
-# postInstallScriptUri
-@environment.pass_env   
-def cli(env, identifier):
+@click.option('--name', help="Scale group's name.")
+@click.option('--min', 'minimum', type=click.INT, help="Set the minimum number of guests")
+@click.option('--max', 'maximum', type=click.INT, help="Set the maximum number of guests")
+@click.option('--userdata', help="User defined metadata string")
+@click.option('--userfile', '-F', help="Read userdata from a file",
+              type=click.Path(exists=True, readable=True, resolve_path=True))
+@click.option('--cpu', type=click.INT, help="Number of CPUs for new guests (existing not effected")
+@click.option('--memory', type=click.INT, help="RAM in MB or GB for new guests (existing not effected")
+@environment.pass_env
+def cli(env, identifier, name, minimum, maximum, userdata, userfile, cpu, memory):
     """Edits an Autoscale group."""
 
+    template = {}
     autoscale = AutoScaleManager(env.client)
-    groups = autoscale.details(identifier)
-    click.echo(groups)
+    group = autoscale.details(identifier)
+
+    template['name'] = name
+    template['minimumMemberCount'] = minimum
+    template['maximumMemberCount'] = maximum
+    virt_template = {}
+    if userdata:
+        virt_template['userData'] = [{"value":userdata}]
+    elif userfile:
+        with open(userfile, 'r') as userfile_obj:
+            virt_template['userData'] = [{"value":userfile_obj.read()}]
+    virt_template['startCpus'] = cpu
+    virt_template['maxMemory'] = memory
+
+    # Remove any entries that are `None` as the API will complain about them.
+    template['virtualGuestMemberTemplate'] = clean_dict(virt_template)
+    clean_template = clean_dict(template)
+
+    # If there are any values edited in the template, we need to get the OLD template values and replace them.
+    if template['virtualGuestMemberTemplate']:
+        # Update old template with new values
+        for key, value in clean_template['virtualGuestMemberTemplate'].items():
+            group['virtualGuestMemberTemplate'][key] = value
+        clean_template['virtualGuestMemberTemplate'] = group['virtualGuestMemberTemplate']
+
+    result = autoscale.edit(identifier, clean_template)
+    click.echo("Done")
+
+
+def clean_dict(dictionary):
+    """Removes any `None` entires from the dictionary"""
+    return {k: v for k, v in dictionary.items() if v}

SoftLayer/fixtures/SoftLayer_Scale_Group.py

@@ -453,3 +453,5 @@
         }
     },
 ]
+
+editObject = True

SoftLayer/managers/autoscale.py

@@ -103,3 +103,16 @@ def get_virtual_guests(self, identifier, mask=None):
             https://sldn.softlayer.com/reference/services/SoftLayer_Scale_Group/getVirtualGuestMembers/
         """
         return self.client.call('SoftLayer_Scale_Group', 'getVirtualGuestMembers', id=identifier, mask=mask, iter=True)
+
+    def edit(self, identifier, template):
+        """Calls `SoftLayer_Scale_Group::editObject()`_
+
+        :param identifier: SoftLayer_Scale_Group id
+        :param template: `SoftLayer_Scale_Group`_
+        .. _SoftLayer_Scale_Group::editObject():
+            https://sldn.softlayer.com/reference/services/SoftLayer_Scale_Group/editObject/
+        .. _SoftLayer_Scale_Group: https://sldn.softlayer.com/reference/datatypes/SoftLayer_Scale_Group/
+        """
+
+        
+        return self.client.call('SoftLayer_Scale_Group', 'editObject', template, id=identifier)

tests/CLI/modules/autoscale_tests.py

@@ -7,6 +7,9 @@
 
     Tests for the autoscale cli command
 """
+import mock
+import tempfile
+from SoftLayer import fixtures
 from SoftLayer import testing
 
 
@@ -49,6 +52,33 @@ def test_autoscale_tag(self):
         result = self.run_command(['autoscale', 'tag', '12345'])
         self.assert_no_fail(result)
 
-    def test_autoscale_edit(self):
-        result = self.run_command(['autoscale', 'edit', '12345'])
+    @mock.patch('SoftLayer.managers.autoscale.AutoScaleManager.edit')
+    def test_autoscale_edit(self, manager):
+        result = self.run_command(['autoscale', 'edit', '12345', '--name', 'test'])
         self.assert_no_fail(result)
+        manager.assert_called_with('12345', {'name': 'test'})
+
+    @mock.patch('SoftLayer.managers.autoscale.AutoScaleManager.edit')
+    def test_autoscale_edit_userdata(self, manager):
+        group = fixtures.SoftLayer_Scale_Group.getObject
+        template = {
+            'virtualGuestMemberTemplate': group['virtualGuestMemberTemplate']
+        }
+        template['virtualGuestMemberTemplate']['userData'] = [{'value': 'test'}]
+
+        result = self.run_command(['autoscale', 'edit', '12345', '--userdata', 'test'])
+        self.assert_no_fail(result)
+        manager.assert_called_with('12345', template)
+
+    @mock.patch('SoftLayer.managers.autoscale.AutoScaleManager.edit')
+    def test_autoscale_edit_userfile(self, manager):
+        group = fixtures.SoftLayer_Scale_Group.getObject
+        template = {
+            'virtualGuestMemberTemplate': group['virtualGuestMemberTemplate']
+        }
+        template['virtualGuestMemberTemplate']['userData'] = [{'value': ''}]
+
+        with tempfile.NamedTemporaryFile() as userfile:
+            result = self.run_command(['autoscale', 'edit', '12345', '--userfile', userfile.name])
+        self.assert_no_fail(result)
+        manager.assert_called_with('12345', template)

tests/managers/autoscale_tests.py

@@ -114,3 +114,12 @@ def test_autoscale_get_virtual_guests_mask(self):
             identifier=11111,
             mask=test_mask
         )
+
+    def test_edit_object(self):
+        template =  {'name': 'test'}
+        self.autoscale.edit(12345, template)
+        self.assert_called_with(
+            'SoftLayer_Scale_Group',
+            'editObject',
+            args=(template,),
+            identifier=12345)