adding unit tests

Author: allmightyspiff

SoftLayer/CLI/virt/migrate.py

@@ -61,7 +61,7 @@ def cli(env, guest, migrate_all, host):
     elif migrate_all:
         require_migration = vsi.list_instances(filter=pending_filter, mask="mask[id]")
         for vsi_object in require_migration:
-            migrate(vsi, guest)
+            migrate(vsi, vsi_object['id'])
     # Just migrate based on the options
     else:
         migrate(vsi, guest, host)

SoftLayer/fixtures/SoftLayer_Virtual_Guest.py

@@ -767,3 +767,6 @@
         }
     }
 ]
+
+migrate = True
+migrateDedicatedHost = True

SoftLayer/testing/__init__.py

@@ -142,6 +142,16 @@ def assert_called_with(self, service, method, **props):
 
         raise AssertionError('%s::%s was not called with given properties: %s' % (service, method, props))
 
+    def assert_not_called_with(self, service, method, **props):
+        """Used to assert that API calls were NOT called with given properties.
+
+        Props are properties of the given transport.Request object.
+        """
+
+        if self.calls(service, method, **props):
+            raise AssertionError('%s::%s was called with given properties: %s' % (service, method, props))
+
+
     def assert_no_fail(self, result):
         """Fail when a failing click result has an error"""
         if result.exception:

tests/CLI/modules/vs/vs_tests.py

@@ -815,3 +815,46 @@ def test_billing(self):
         }
         self.assert_no_fail(result)
         self.assertEqual(json.loads(result.output), vir_billing)
+
+    def test_vs_migrate_list(self):
+        result = self.run_command(['vs', 'migrate'])
+        self.assert_no_fail(result)
+        self.assert_called_with('SoftLayer_Account', 'getVirtualGuests')
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrate')
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost')
+
+    def test_vs_migrate_guest(self):
+        result = self.run_command(['vs', 'migrate', '-g', '100'])
+        
+        self.assert_no_fail(result)
+        self.assertIn('Started a migration on', result.output)
+        self.assert_not_called_with('SoftLayer_Account', 'getVirtualGuests')
+        self.assert_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=100)
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost')
+
+    def test_vs_migrate_all(self):
+        result = self.run_command(['vs', 'migrate', '-a'])
+        self.assert_no_fail(result)
+        self.assertIn('Started a migration on', result.output)
+        self.assert_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=100)
+        self.assert_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=104)
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost')
+
+    def test_vs_migrate_dedicated(self):
+        result = self.run_command(['vs', 'migrate', '-g', '100', '-h', '999'])
+        self.assert_no_fail(result)
+        self.assertIn('Started a migration on', result.output)
+        self.assert_not_called_with('SoftLayer_Account', 'getVirtualGuests')
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=100)
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost', args=(999), identifier=100)
+
+    def test_vs_migrate_exception(self):
+        ex = SoftLayerAPIError('SoftLayer_Exception', 'PROBLEM')
+        mock = self.set_mock('SoftLayer_Virtual_Guest', 'migrate')
+        mock.side_effect = ex
+        result = self.run_command(['vs', 'migrate', '-g', '100'])
+        self.assert_no_fail(result)
+        self.assertIn('Failed to migrate', result.output)
+        self.assert_not_called_with('SoftLayer_Account', 'getVirtualGuests')
+        self.assert_called_with('SoftLayer_Virtual_Guest', 'migrate', identifier=100)
+        self.assert_not_called_with('SoftLayer_Virtual_Guest', 'migrateDedicatedHost', args=(999), identifier=100)