From cba9ab5d9efd63f3556a9108118ff560d6998807 Mon Sep 17 00:00:00 2001 From: Daniel-Khodabakhsh Date: Mon, 7 Nov 2022 11:15:15 -0800 Subject: [PATCH 1/2] Fix module naming typo. --- .../multi-module-not-on-root-with-correct-config/build.sbt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sbt-test/sbt-sonar/multi-module-not-on-root-with-correct-config/build.sbt b/src/sbt-test/sbt-sonar/multi-module-not-on-root-with-correct-config/build.sbt index 950de0e..ba05cd2 100644 --- a/src/sbt-test/sbt-sonar/multi-module-not-on-root-with-correct-config/build.sbt +++ b/src/sbt-test/sbt-sonar/multi-module-not-on-root-with-correct-config/build.sbt @@ -20,11 +20,11 @@ lazy val sonarSettings = Seq( lazy val module1 = (project in file("test-1/module1")) .settings(baseSettings) - .settings(name := "module2nirwcc") + .settings(name := "module1nirwcc") lazy val module2 = (project in file("test-2/module2")) .settings(baseSettings) - .settings(name := "module1nirwcc") + .settings(name := "module2nirwcc") lazy val multiModule = (project in file(".")) .aggregate(module1, module2) From 32348b4b638581da3ec55561d7dc1b02ebc85c11 Mon Sep 17 00:00:00 2001 From: Daniel-Khodabakhsh Date: Mon, 7 Nov 2022 11:53:09 -0800 Subject: [PATCH 2/2] Remove uneeded `name` property from modules. SBT automatically assigns module names equal to the val name if the `name` property is omitted. Leverage this for modules `module1` and `module2`. --- src/sbt-test/sbt-sonar/multi-module/build.sbt | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/sbt-test/sbt-sonar/multi-module/build.sbt b/src/sbt-test/sbt-sonar/multi-module/build.sbt index 652a06b..9c7a94a 100644 --- a/src/sbt-test/sbt-sonar/multi-module/build.sbt +++ b/src/sbt-test/sbt-sonar/multi-module/build.sbt @@ -18,11 +18,9 @@ lazy val sonarSettings = Seq( lazy val module1 = (project in file("module1")) .settings(baseSettings) - .settings(name := "module2") lazy val module2 = (project in file("module2")) .settings(baseSettings) - .settings(name := "module1") lazy val multiModule = (project in file(".")) .aggregate(module1, module2)