Skip to content

CONSUME assumes adv gain from milk of magnesium even if it is not being used #19

@c22

Description

@c22

CONSUME script accounts for the 5 extra adventures even if the diet actions don't end up including milk of magnesium (eg. when you're eating on an extreme budget).

This leads to incorrect estimates of adventure gain. You can test it out by hand crafting a diet like so:

record Diet
actions => aggregate DietAction [int]
  0 => record DietAction
    it => sausage without a cause
    sk => none
    organ => 1
    space => 10
    tools => aggregate item [int]
    mayo => none
    cleanings => aggregate OrganCleaning [int]
    shrug => none
  1 => record DietAction
    it => fusilli marrownarrow
    sk => none
    organ => 1
    space => 5
    tools => aggregate item [int]
    mayo => none
    cleanings => aggregate OrganCleaning [int]
    shrug => none
counts => aggregate int [item]
  fusilli marrownarrow => 1
  sausage without a cause => 1
lastmayo => none
nightcap => false

When you print this diet out, it will say "Adventure yield should be roughly 71-74" whereas it should say "Adventure yield should be roughly 66-69".

The 5 extra adventures should only be included if the diet contains a 'milk of magnesium' action, not simply because the Diet contains DietActions of the stomach.

Probably also affects 'potion of the field gar' handling as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions