Consistency in use of source in docker images

[ivanperez-keera]

This is a minor thing, but, as I was going through the image, I noticed that these two source invocations are written in different ways:

docker/space_robots/Dockerfile

Lines 80 to 87 in 76cd412

	RUN sudo apt-get update -y \
	&& /bin/bash -c 'source "${SPACEROS_DIR}/install/setup.bash"' \
	&& /bin/bash -c 'source "${MOVEIT2_DIR}/install/setup.bash"' \
	&& rosdep install --from-paths src --ignore-src -r -y --rosdistro ${ROSDISTRO}
	# Build the demo
	RUN /bin/bash -c 'source ${SPACEROS_DIR}/install/setup.bash && source ${MOVEIT2_DIR}/install/setup.bash \
	&& colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release'

It'll help us catch errors and keep things well maintained if we are consistent. I think we should pick either this way of doing it:

docker/space_robots/Dockerfile

Lines 81 to 82 in 76cd412

	&& /bin/bash -c 'source "${SPACEROS_DIR}/install/setup.bash"' \
	&& /bin/bash -c 'source "${MOVEIT2_DIR}/install/setup.bash"' \

or this way:

docker/space_robots/Dockerfile

Line 86 in 76cd412

RUN /bin/bash -c 'source ${SPACEROS_DIR}/install/setup.bash && source ${MOVEIT2_DIR}/install/setup.bash \

I personally like the former because I don't like long lines. I find it much harder to catch mistakes in long lines. Also, editors can break lines but github doesn't, and it leads to git diffs that are harder to process.

[ivanperez-keera]

This is minor and perhaps not a priority. I'm filing it here first to see what people think. If we want to do something about it, we can promote this discussion to an issue.

[Bckempa]

I don't think those are equivalent. In the first version the overlays are sourced in subprocesses that are immediately discarded, while in the second version the Space ROS and Move It 2 workspaces are sourced when rosdep is called.

[ivanperez-keera]

I didn't notice the end '. If what you are saying is right, do the first two have no effect then?

[Bckempa]

Correct. I haven't tested it yet, but I assume it would impact the rosdep call because --ignore-src will skip installing any package found in the ROS_PACKAGE_PATH which would be modified by sourcing the two workspaces.

[Bckempa]

I'll confirm there is an impact and convert this to a bug if necessary.