Make golint && go test -cover happy

Author: spacewander

suffix.go

@@ -136,11 +136,11 @@ func (node *_Node) insert(originKey []byte, key []byte, value interface{}) (
 				//	insert a new Leaf
 				newNode := &_Node{
 					edges: []*_Edge{
-						&_Edge{
+						{
 							label: []byte{},
 							point: point,
 						},
-						&_Edge{
+						{
 							label: label,
 							point: &_Leaf{
 								originKey: originKey,
@@ -433,11 +433,13 @@ func (node *_Node) walkNode(suffix [][]byte, f func(labels [][]byte, value inter
 	}
 }
 
+// Tree represents a suffix tree.
 type Tree struct {
 	root      *_Node
 	leavesNum int
 }
 
+// NewTree create a suffix tree for future usage.
 func NewTree() *Tree {
 	return &Tree{
 		root: &_Node{
@@ -455,12 +457,12 @@ func (tree *Tree) Insert(key []byte, value interface{}) (oldValue interface{}, o
 	}
 	oldValue, ok = tree.root.insert(key, key, value)
 	if ok && oldValue == nil {
-		tree.leavesNum += 1
+		tree.leavesNum++
 	}
 	return oldValue, ok
 }
 
-// Given a key, Get returns the value itself and a boolean to indicate
+// Get returns the value of given key and a boolean to indicate
 // whether the value is found.
 func (tree *Tree) Get(key []byte) (value interface{}, found bool) {
 	if key == nil || len(tree.root.edges) == 0 {
@@ -480,15 +482,15 @@ func (tree *Tree) LongestSuffix(key []byte) (matchedKey []byte, value interface{
 	return tree.root.longestSuffix(key)
 }
 
-// Given a key, Remove returns the value itself and a boolean to indicate
+// Remove returns the value of given key and a boolean to indicate
 // whethe the value is found. Then the value will be removed.
 func (tree *Tree) Remove(key []byte) (oldValue interface{}, found bool) {
 	if key == nil || len(tree.root.edges) == 0 {
 		return nil, false
 	}
 	oldValue, found, _ = tree.root.remove(key)
 	if found {
-		tree.leavesNum -= 1
+		tree.leavesNum--
 	}
 	return oldValue, found
 }

suffix_test.go

@@ -257,6 +257,28 @@ func TestWalkSuffix_Base(t *testing.T) {
 	assert.Equal(t, 0, count)
 }
 
+func TestInvalidInput(t *testing.T) {
+	lists, tree := getFixtures()
+	count := len(lists)
+	tree.WalkSuffix(nil, func(key []byte, value interface{}) bool {
+		count--
+		return false
+	})
+	assert.Equal(t, 0, count)
+
+	_, ok := tree.Insert(nil, "any")
+	assert.False(t, ok)
+
+	_, found := tree.Get(nil)
+	assert.False(t, found)
+
+	_, found = tree.Remove(nil)
+	assert.False(t, found)
+
+	_, _, found = tree.LongestSuffix(nil)
+	assert.False(t, found)
+}
+
 func dumpTestData(wordRef map[string]bool, tree *Tree, ops []string, errMsg string) {
 	opDumpFile, _ := ioutil.TempFile("", "suffix_test_op_dump_")
 	defer opDumpFile.Close()
@@ -266,7 +288,7 @@ func dumpTestData(wordRef map[string]bool, tree *Tree, ops []string, errMsg stri
 	}
 	println("\nWord status:")
 	words := []string{}
-	for word, _ := range wordRef {
+	for word := range wordRef {
 		words = append(words, word)
 	}
 	sort.Sort(sort.StringSlice(words))
@@ -371,7 +393,7 @@ func TestAlhoc(t *testing.T) {
 			bs := string(b)
 			if _, ok := wordRef[bs]; !ok {
 				wordRef[bs] = true
-				wordCount += 1
+				wordCount++
 			}
 			ops = append(ops, "Insert\t"+bs)
 			tree.Insert(b, bs)
@@ -398,7 +420,7 @@ func TestAlhoc(t *testing.T) {
 				existedNum := 0
 				for _, existed := range wordRef {
 					if existed {
-						existedNum += 1
+						existedNum++
 					}
 				}
 				if tree.Len() != existedNum {