Skip to content

Commit 09208ac

Browse files
authored
Merge pull request #266 from sparksuite/demo-site-crash-fix
Refactor pattern of spreading empty arrays to Array.from
2 parents 3d7aa9f + 15bb24f commit 09208ac

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-accessible-dropdown-menu-hook",
3-
"version": "2.2.0",
3+
"version": "2.2.1",
44
"description": "A simple Hook for creating fully accessible dropdown menus in React",
55
"main": "dist/use-dropdown-menu.js",
66
"types": "dist/use-dropdown-menu.d.ts",

src/use-dropdown-menu.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export default function useDropdownMenu(itemCount: number): DropdownMenuResponse
3636

3737
// Initialize refs and update them when the item count changes
3838
useEffect(() => {
39-
itemRefs.current = [...Array<undefined>(itemCount)].map(() => createRef<HTMLAnchorElement>());
39+
itemRefs.current = Array.from({ length: itemCount }, () => createRef<HTMLAnchorElement>());
4040
}, [itemCount]);
4141

4242
// Create type guard
@@ -199,7 +199,7 @@ export default function useDropdownMenu(itemCount: number): DropdownMenuResponse
199199
'aria-expanded': isOpen,
200200
};
201201

202-
const itemProps = [...Array<undefined>(itemCount)].map((_ignore, index) => ({
202+
const itemProps = Array.from({ length: itemCount }, (_ignore, index) => ({
203203
onKeyDown: itemListener,
204204
tabIndex: -1,
205205
role: 'menuitem',

0 commit comments

Comments
 (0)