Skip to content

Update migration script #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 26, 2025
Merged

Update migration script #1224

merged 18 commits into from
May 26, 2025

Conversation

nnhjy
Copy link
Member

@nnhjy nnhjy commented May 26, 2025

Renew PR #1205 to fix issue #1222

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (d2d9375) to head (08eabe1).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   87.51%   86.22%   -1.30%     
==========================================
  Files         146      147       +1     
  Lines        4501     4536      +35     
==========================================
- Hits         3939     3911      -28     
- Misses        562      625      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nnhjy nnhjy merged commit bebde70 into master May 26, 2025
6 checks passed
@nnhjy nnhjy deleted the update-migration-script branch May 26, 2025 23:06
ll-ara pushed a commit to ll-ara/SpineOpt.jl that referenced this pull request May 27, 2025
* Add migration for the new parameter

* build and deploy the migration function and update template version

* add unit test

* update DB version of the examples

* use new method in run_request() for adding parameter value_list

* Add migration for the new parameter

* build and deploy the migration function and update template version

* update DB version of the examples

* use new method in run_request() for adding parameter value_list

* Update SpineOpt DB version

* Add new parameters to the migration script

* fix db version upgrade conflicts

* update SpineOpt database version

* update SpineOpt template

* Add tests for the migration

* Try to fix codecov

* fix conflicts when new parameter value list is defined

---------

Co-authored-by: Diego Alejandro Tejada Arango <diego.tejadaarango@tno.nl>
ll-ara pushed a commit to ll-ara/SpineOpt.jl that referenced this pull request May 28, 2025
* Add migration for the new parameter

* build and deploy the migration function and update template version

* add unit test

* update DB version of the examples

* use new method in run_request() for adding parameter value_list

* Add migration for the new parameter

* build and deploy the migration function and update template version

* update DB version of the examples

* use new method in run_request() for adding parameter value_list

* Update SpineOpt DB version

* Add new parameters to the migration script

* fix db version upgrade conflicts

* update SpineOpt database version

* update SpineOpt template

* Add tests for the migration

* Try to fix codecov

* fix conflicts when new parameter value list is defined

---------

Co-authored-by: Diego Alejandro Tejada Arango <diego.tejadaarango@tno.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants