From 2085b367591e70a09e05418010867aeec44f6083 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Thu, 1 May 2014 01:10:10 -0400 Subject: [PATCH 1/2] Check if input is an array In some cases the $input value (after fromJSON conversion) is not an array, in which case the logs can fill php notices/errors. Added this simple check to avoid that. --- .../formit/elements/snippets/snippet.formitischecked.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/components/formit/elements/snippets/snippet.formitischecked.php b/core/components/formit/elements/snippets/snippet.formitischecked.php index 8c42798c..c7fd4439 100644 --- a/core/components/formit/elements/snippets/snippet.formitischecked.php +++ b/core/components/formit/elements/snippets/snippet.formitischecked.php @@ -31,7 +31,7 @@ $output = ' checked="checked"'; } $input = $modx->fromJSON($input); -if (in_array($options,$input)) { +if (is_array($input) && in_array($options,$input)) { $output = ' checked="checked"'; } return $output; From 978748e43b62ef2212a96245911e9bdfe35d3b18 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Thu, 1 May 2014 01:17:39 -0400 Subject: [PATCH 2/2] Check if input is an array In some cases the $input value (after fromJSON conversion) is not an array, in which case the logs can fill up with php notices/errors (especially when a form has several selects/options). Added this simple check to avoid that. --- .../formit/elements/snippets/snippet.formitisselected.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/components/formit/elements/snippets/snippet.formitisselected.php b/core/components/formit/elements/snippets/snippet.formitisselected.php index 2cfd4a1e..f77e2761 100644 --- a/core/components/formit/elements/snippets/snippet.formitisselected.php +++ b/core/components/formit/elements/snippets/snippet.formitisselected.php @@ -31,7 +31,7 @@ $output = ' selected="selected"'; } $input = $modx->fromJSON($input); -if (in_array($options,$input)) { +if (is_array($input) && in_array($options,$input)) { $output = ' selected="selected"'; } return $output;