Skip to content

Commit 8e0a4ba

Browse files
committed
Remove unchecked splunk restart in test_modular_input_kinds.py
These do not seem to be necessary, install_app_from_collection internally handles restarting of splunk. Also other tests that call install_app_from_collection do not restart splunk before.
1 parent 1c2cc7b commit 8e0a4ba

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

tests/integration/test_modular_input_kinds.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@
2222

2323

2424
class ModularInputKindTestCase(testlib.SDKTestCase):
25-
def setUp(self):
26-
super().setUp()
27-
self.uncheckedRestartSplunk()
28-
2925
@pytest.mark.app
3026
def test_list_arguments(self):
3127
self.install_app_from_collection("modular_inputs")

tests/testlib.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,6 @@ def pathInApp(self, appName, pathComponents):
221221
appPath = separator.join([splunkHome, "etc", "apps", appName] + pathComponents)
222222
return appPath
223223

224-
def uncheckedRestartSplunk(self, timeout=240):
225-
self.service.restart(timeout)
226-
227224
def restartSplunk(self, timeout=240):
228225
if self.service.restart_required:
229226
self.service.restart(timeout)

0 commit comments

Comments
 (0)