Integrate Pierre's code #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes should not break anything when importing the bundle as before, see 'src/lnn.js' for the compatibility. Not all functions were converted to ES6 classes, but the individual files (modules) should be individually importable. Moving js-client to ES6 allows the JS code to be used for other libraries, in particular for Lightnion's WebSocket, and pave the way for unit-testing.
Uses mocha and runs on node with `make test`.
In preparation for the Lightnion WebSocket. Unit tests included.
An implementation of a WebSocket Client that is redirected through Tor thanks to Lightnion. Exported as `lnn.websocket`. See the readme.
Configuration is in `.eslintrc.json`.
Testing Lightnion WebSocket in a selenium-drived browser, with local test chutney network, local Lightnion proxy, and local WebSocket servers. See README.md in `js-client/integration-tests/lightnion-websocket/`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Pierre's code.
Fix key handling bug.
Change websocket endpoint to ease deployment.