Skip to content

Commit 11d6c43

Browse files
committed
Test that default max HTTP request header aligns with Tomcat
Closes gh-46977
1 parent 985e108 commit 11d6c43

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.apache.catalina.valves.AccessLogValve;
3131
import org.apache.catalina.valves.RemoteIpValve;
3232
import org.apache.coyote.AbstractProtocol;
33+
import org.apache.coyote.http11.Http11Nio2Protocol;
3334
import org.apache.tomcat.util.net.AbstractEndpoint;
3435
import org.eclipse.jetty.ee10.servlet.ServletContextHandler;
3536
import org.eclipse.jetty.server.Server;
@@ -220,6 +221,12 @@ void testCustomizeMaxHttpRequestHeaderSizeUseBytesByDefault() {
220221
assertThat(this.properties.getMaxHttpRequestHeaderSize()).isEqualTo(DataSize.ofKilobytes(1));
221222
}
222223

224+
@Test
225+
void defaultMaxHttpRequestHeaderSizeMatchesTomcatsDefault() {
226+
assertThat(this.properties.getMaxHttpRequestHeaderSize().toBytes())
227+
.isEqualTo(new Http11Nio2Protocol().getMaxHttpRequestHeaderSize());
228+
}
229+
223230
@Test
224231
void testCustomizeTomcatMaxThreads() {
225232
bind("server.tomcat.threads.max", "10");

0 commit comments

Comments
 (0)