Skip to content

Commit 223f2be

Browse files
committed
Inject InfoContributors instead of exposing them on InfoEndpoint
Closes gh-13586
1 parent 2cdc93c commit 223f2be

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/reactive/ReactiveCloudFoundryActuatorAutoConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import java.util.stream.Collectors;
2525

2626
import org.springframework.beans.BeansException;
27+
import org.springframework.beans.factory.ObjectProvider;
2728
import org.springframework.beans.factory.config.BeanPostProcessor;
2829
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer;
2930
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.servlet.CloudFoundryInfoEndpointWebExtension;
@@ -99,9 +100,8 @@ public CloudFoundryReactiveHealthEndpointWebExtension cloudFoundryReactiveHealth
99100
@ConditionalOnExposedEndpoint
100101
@ConditionalOnBean({ InfoEndpoint.class, GitProperties.class })
101102
public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension(
102-
InfoEndpoint infoEndpoint, GitProperties properties) {
103-
List<InfoContributor> existingContributors = infoEndpoint.getInfoContributors();
104-
List<InfoContributor> contributors = existingContributors.stream()
103+
GitProperties properties, ObjectProvider<InfoContributor> infoContributors) {
104+
List<InfoContributor> contributors = infoContributors.orderedStream()
105105
.map((infoContributor) -> {
106106
if (infoContributor instanceof GitInfoContributor) {
107107
return new GitInfoContributor(properties,

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/servlet/CloudFoundryActuatorAutoConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import java.util.List;
2424
import java.util.stream.Collectors;
2525

26+
import org.springframework.beans.factory.ObjectProvider;
2627
import org.springframework.boot.actuate.autoconfigure.cloudfoundry.CloudFoundryWebEndpointDiscoverer;
2728
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint;
2829
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnExposedEndpoint;
@@ -100,9 +101,8 @@ public CloudFoundryHealthEndpointWebExtension cloudFoundryHealthEndpointWebExten
100101
@ConditionalOnExposedEndpoint
101102
@ConditionalOnBean({ InfoEndpoint.class, GitProperties.class })
102103
public CloudFoundryInfoEndpointWebExtension cloudFoundryInfoEndpointWebExtension(
103-
InfoEndpoint infoEndpoint, GitProperties properties) {
104-
List<InfoContributor> existingContributors = infoEndpoint.getInfoContributors();
105-
List<InfoContributor> contributors = existingContributors.stream()
104+
GitProperties properties, ObjectProvider<InfoContributor> infoContributors) {
105+
List<InfoContributor> contributors = infoContributors.orderedStream()
106106
.map((infoContributor) -> {
107107
if (infoContributor instanceof GitInfoContributor) {
108108
return new GitInfoContributor(properties,

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoEndpoint.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,4 @@ public Map<String, Object> info() {
5555
return build.getDetails();
5656
}
5757

58-
public List<InfoContributor> getInfoContributors() {
59-
return this.infoContributors;
60-
}
61-
6258
}

0 commit comments

Comments
 (0)