Disable LiveReload server by default

This commit changes the default value of configuration property
`spring.devtools.livereload.enabled` to `false`.

Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>

Author: vpavic

documentation/spring-boot-docs/src/docs/antora/modules/reference/pages/using/devtools.adoc

@@ -287,7 +287,7 @@ The `spring-boot-devtools` module includes an embedded LiveReload server that ca
 LiveReload browser extensions are freely available for Chrome, Firefox and Safari.
 You can find these extensions by searching 'LiveReload' in the marketplace or store of your chosen browser.
 
-If you do not want to start the LiveReload server when your application runs, you can set the configprop:spring.devtools.livereload.enabled[] property to `false`.
+If you want to start the LiveReload server when your application runs, you can set the configprop:spring.devtools.livereload.enabled[] property to `true`.
 
 NOTE: You can only run one LiveReload server at a time.
 Before starting your application, ensure that no other LiveReload servers are running.

module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/DevToolsProperties.java

@@ -193,7 +193,7 @@ public static class Livereload {
 		/**
 		 * Whether to enable a livereload.com-compatible server.
 		 */
-		private boolean enabled = true;
+		private boolean enabled = false;
 
 		/**
 		 * Server port.

module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/LocalDevToolsAutoConfiguration.java

@@ -70,7 +70,7 @@ public final class LocalDevToolsAutoConfiguration {
 	 * Local LiveReload configuration.
 	 */
 	@Configuration(proxyBeanMethods = false)
-	@ConditionalOnBooleanProperty(name = "spring.devtools.livereload.enabled", matchIfMissing = true)
+	@ConditionalOnBooleanProperty(name = "spring.devtools.livereload.enabled")
 	static class LiveReloadConfiguration {
 
 		@Bean

module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/remote/client/RemoteClientConfiguration.java

@@ -131,7 +131,7 @@ private void logWarnings() {
 	 * LiveReload configuration.
 	 */
 	@Configuration(proxyBeanMethods = false)
-	@ConditionalOnBooleanProperty(name = "spring.devtools.livereload.enabled", matchIfMissing = true)
+	@ConditionalOnBooleanProperty(name = "spring.devtools.livereload.enabled")
 	static class LiveReloadConfiguration {
 
 		private final DevToolsProperties properties;

module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/LocalDevToolsAutoConfigurationTests.java

@@ -111,16 +111,11 @@ void resourceCachePeriodIsZero() throws Exception {
 		assertThat(properties.getCache().getPeriod()).isZero();
 	}
 
-	@Test
-	void liveReloadServer() throws Exception {
-		this.context = getContext(() -> initializeAndRun(Config.class));
-		LiveReloadServer server = this.context.getBean(LiveReloadServer.class);
-		assertThat(server.isStarted()).isTrue();
-	}
-
 	@Test
 	void liveReloadTriggeredOnContextRefresh() throws Exception {
-		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class));
+		Map<String, Object> properties = new HashMap<>();
+		properties.put("spring.devtools.livereload.enabled", true);
+		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class, properties));
 		LiveReloadServer server = this.context.getBean(LiveReloadServer.class);
 		reset(server);
 		this.context.publishEvent(new ContextRefreshedEvent(this.context));
@@ -129,7 +124,9 @@ void liveReloadTriggeredOnContextRefresh() throws Exception {
 
 	@Test
 	void liveReloadTriggeredOnClassPathChangeWithoutRestart() throws Exception {
-		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class));
+		Map<String, Object> properties = new HashMap<>();
+		properties.put("spring.devtools.livereload.enabled", true);
+		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class, properties));
 		LiveReloadServer server = this.context.getBean(LiveReloadServer.class);
 		reset(server);
 		ClassPathChangedEvent event = new ClassPathChangedEvent(this.context, Collections.emptySet(), false);
@@ -139,7 +136,9 @@ void liveReloadTriggeredOnClassPathChangeWithoutRestart() throws Exception {
 
 	@Test
 	void liveReloadNotTriggeredOnClassPathChangeWithRestart() throws Exception {
-		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class));
+		Map<String, Object> properties = new HashMap<>();
+		properties.put("spring.devtools.livereload.enabled", true);
+		this.context = getContext(() -> initializeAndRun(ConfigWithMockLiveReload.class, properties));
 		LiveReloadServer server = this.context.getBean(LiveReloadServer.class);
 		reset(server);
 		ClassPathChangedEvent event = new ClassPathChangedEvent(this.context, Collections.emptySet(), true);
@@ -148,10 +147,8 @@ void liveReloadNotTriggeredOnClassPathChangeWithRestart() throws Exception {
 	}
 
 	@Test
-	void liveReloadDisabled() throws Exception {
-		Map<String, Object> properties = new HashMap<>();
-		properties.put("spring.devtools.livereload.enabled", false);
-		this.context = getContext(() -> initializeAndRun(Config.class, properties));
+	void liveReloadDisabledByDefault() throws Exception {
+		this.context = getContext(() -> initializeAndRun(Config.class));
 		assertThatExceptionOfType(NoSuchBeanDefinitionException.class)
 			.isThrownBy(() -> this.context.getBean(OptionalLiveReloadServer.class));
 	}

module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/remote/client/RemoteClientConfigurationTests.java

@@ -102,8 +102,8 @@ void failIfNoSecret() {
 	}
 
 	@Test
-	void liveReloadOnClassPathChanged() throws Exception {
-		configure();
+	void liveReloadOnClassPathChanged() {
+		configure("spring.devtools.livereload.enabled:true");
 		Set<ChangedFiles> changeSet = new HashSet<>();
 		ClassPathChangedEvent event = new ClassPathChangedEvent(this, changeSet, false);
 		this.clientContext.publishEvent(event);
@@ -112,8 +112,8 @@ void liveReloadOnClassPathChanged() throws Exception {
 	}
 
 	@Test
-	void liveReloadDisabled() {
-		configure("spring.devtools.livereload.enabled:false");
+	void liveReloadDisabledByDefault() {
+		configure();
 		assertThatExceptionOfType(NoSuchBeanDefinitionException.class)
 			.isThrownBy(() -> this.context.getBean(OptionalLiveReloadServer.class));
 	}