Skip to content

Commit 99ad379

Browse files
committed
Use string concatenation in QueryExtractorDelegate instead of String.format(…).
We now use string concatenation during query extraction to avoid String.format(…) overhead for unknown queries. Closes #1186
1 parent 538954e commit 99ad379

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/QueryExtractorDelegate.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,16 @@
1515
*/
1616
package org.springframework.data.cassandra.core.cql;
1717

18-
import org.springframework.lang.Nullable;
19-
2018
import com.datastax.oss.driver.api.core.cql.BatchStatement;
2119
import com.datastax.oss.driver.api.core.cql.BatchableStatement;
2220
import com.datastax.oss.driver.api.core.cql.BoundStatement;
2321
import com.datastax.oss.driver.api.core.cql.PreparedStatement;
2422
import com.datastax.oss.driver.api.core.cql.SimpleStatement;
2523
import com.datastax.oss.driver.api.core.cql.Statement;
2624

25+
import org.springframework.lang.Nullable;
26+
import org.springframework.util.ObjectUtils;
27+
2728
/**
2829
* Utility to extract CQL queries from a {@link Statement}.
2930
*
@@ -68,12 +69,16 @@ public static String getCql(@Nullable Object statement) {
6869
for (BatchableStatement<?> batchableStatement : ((BatchStatement) statement)) {
6970

7071
String query = getCql(batchableStatement);
71-
builder.append(query).append(query.endsWith(";") ? "" : ";");
72+
builder.append(query);
73+
74+
if (!ObjectUtils.isEmpty(query)) {
75+
builder.append(query.endsWith(";") ? "" : ";");
76+
}
7277
}
7378

7479
return builder.toString();
7580
}
7681

77-
return String.format("Unknown: %s", statement);
82+
return "Unknown: " + statement;
7883
}
7984
}

0 commit comments

Comments
 (0)