Skip to content

Commit 7ce3173

Browse files
committed
Upgrade dependencies; fix compatibility in tests
1 parent 56474a5 commit 7ce3173

File tree

3 files changed

+26
-36
lines changed

3 files changed

+26
-36
lines changed

build.gradle

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ ext {
4747
modifiedFiles =
4848
files(grgit.status().unstaged.modified).filter{ f -> f.name.endsWith('.java') || f.name.endsWith('.kt') }
4949

50-
activeMqVersion = '5.16.1'
50+
activeMqVersion = '5.16.2'
5151
apacheSshdVersion = '2.5.1'
5252
aspectjVersion = '1.9.6'
5353
assertjVersion = '3.17.2'
@@ -79,35 +79,35 @@ ext {
7979
jschVersion = '0.1.55'
8080
jsonpathVersion = '2.4.0'
8181
junit4Version = '4.13.2'
82-
junitJupiterVersion = '5.7.1'
82+
junitJupiterVersion = '5.7.2'
8383
jythonVersion = '2.7.2'
8484
kryoShadedVersion = '4.0.2'
85-
lettuceVersion = '6.0.4.RELEASE'
85+
lettuceVersion = '6.0.5.RELEASE'
8686
log4jVersion = '2.13.3'
8787
mailVersion = '1.6.7'
88-
micrometerVersion = '1.5.12'
88+
micrometerVersion = '1.5.14'
8989
mockitoVersion = '3.6.28'
9090
mongoDriverVersion = '4.1.2'
9191
mysqlVersion = '8.0.23'
9292
pahoMqttClientVersion = '1.2.5'
9393
postgresVersion = '42.2.19'
9494
r2dbch2Version='0.8.4.RELEASE'
95-
reactorVersion = '2020.0.6'
95+
reactorVersion = '2020.0.7'
9696
resilience4jVersion = '1.6.1'
9797
romeToolsVersion = '1.15.0'
9898
rsocketVersion = '1.1.0'
9999
saajVersion = '1.5.2'
100100
servletApiVersion = '4.0.1'
101101
smackVersion = '4.3.5'
102102
soapVersion = '1.4.0'
103-
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.3.6'
104-
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : '2020.0.8'
105-
springKafkaVersion = '2.6.7'
103+
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.3.7'
104+
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : '2020.0.9'
105+
springKafkaVersion = '2.6.8'
106106
springRetryVersion = '1.3.1'
107107
springSecurityVersion = project.hasProperty('springSecurityVersion') ? project.springSecurityVersion : '5.4.6'
108-
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.3.6'
108+
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.3.7'
109109
springWsVersion = '3.0.10.RELEASE'
110-
tomcatVersion = "9.0.45"
110+
tomcatVersion = "9.0.46"
111111
xstreamVersion = '1.4.16'
112112

113113
javaProjects = subprojects - project(':spring-integration-bom')
@@ -126,7 +126,7 @@ allprojects {
126126
if (version.endsWith('SNAPSHOT')) {
127127
maven { url 'https://repo.spring.io/snapshot' }
128128
}
129-
// maven { url 'https://repo.spring.io/libs-staging-local' }
129+
maven { url 'https://repo.spring.io/libs-staging-local' }
130130
}
131131

132132
ext.javadocLinks = [

spring-integration-amqp/src/test/java/org/springframework/integration/amqp/channel/DispatcherHasNoSubscribersTests.java

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2019 the original author or authors.
2+
* Copyright 2002-2021 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -17,7 +17,7 @@
1717
package org.springframework.integration.amqp.channel;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
20-
import static org.assertj.core.api.Assertions.fail;
20+
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
2121
import static org.mockito.ArgumentMatchers.any;
2222
import static org.mockito.ArgumentMatchers.anyBoolean;
2323
import static org.mockito.ArgumentMatchers.anyString;
@@ -30,7 +30,7 @@
3030
import java.util.List;
3131

3232
import org.apache.commons.logging.Log;
33-
import org.junit.Test;
33+
import org.junit.jupiter.api.Test;
3434

3535
import org.springframework.amqp.core.AmqpTemplate;
3636
import org.springframework.amqp.core.Message;
@@ -56,7 +56,6 @@
5656
*/
5757
public class DispatcherHasNoSubscribersTests {
5858

59-
@SuppressWarnings("unchecked")
6059
@Test
6160
public void testPtP() throws Exception {
6261
final Channel channel = mock(Channel.class);
@@ -79,14 +78,10 @@ public void testPtP() throws Exception {
7978
amqpChannel.afterPropertiesSet();
8079

8180
MessageListener listener = (MessageListener) container.getMessageListener();
82-
try {
83-
listener.onMessage(new Message("Hello world!".getBytes(), null));
84-
fail("Exception expected");
85-
}
86-
catch (MessageDeliveryException e) {
87-
assertThat(e.getMessage())
88-
.contains("Dispatcher has no subscribers for amqp-channel 'noSubscribersChannel'.");
89-
}
81+
82+
assertThatExceptionOfType(MessageDeliveryException.class)
83+
.isThrownBy(() -> listener.onMessage(new Message("Hello world!".getBytes())))
84+
.withMessageContaining("Dispatcher has no subscribers for amqp-channel 'noSubscribersChannel'.");
9085
}
9186

9287
@Test
@@ -99,24 +94,23 @@ public void testPubSub() {
9994
SimpleMessageListenerContainer container = new SimpleMessageListenerContainer();
10095
container.setConnectionFactory(connectionFactory);
10196
AmqpTemplate amqpTemplate = mock(AmqpTemplate.class);
102-
PublishSubscribeAmqpChannel amqpChannel = new PublishSubscribeAmqpChannel("noSubscribersChannel",
103-
container, amqpTemplate);
97+
PublishSubscribeAmqpChannel amqpChannel =
98+
new PublishSubscribeAmqpChannel("noSubscribersChannel", container, amqpTemplate);
10499
amqpChannel.setBeanName("noSubscribersChannel");
105100
amqpChannel.setBeanFactory(mock(BeanFactory.class));
106101
amqpChannel.afterPropertiesSet();
107102

108103
List<String> logList = insertMockLoggerInListener(amqpChannel);
109104
MessageListener listener = (MessageListener) container.getMessageListener();
110-
listener.onMessage(new Message("Hello world!".getBytes(), null));
105+
listener.onMessage(new Message("Hello world!".getBytes()));
111106
verifyLogReceived(logList);
112107
}
113108

114-
private List<String> insertMockLoggerInListener(
115-
PublishSubscribeAmqpChannel channel) {
116-
SimpleMessageListenerContainer container = TestUtils.getPropertyValue(
117-
channel, "container", SimpleMessageListenerContainer.class);
109+
private static List<String> insertMockLoggerInListener(PublishSubscribeAmqpChannel channel) {
110+
SimpleMessageListenerContainer container =
111+
TestUtils.getPropertyValue(channel, "container", SimpleMessageListenerContainer.class);
118112
Log logger = mock(Log.class);
119-
final ArrayList<String> logList = new ArrayList<String>();
113+
final ArrayList<String> logList = new ArrayList<>();
120114
doAnswer(invocation -> {
121115
String message = invocation.getArgument(0);
122116
if (message.startsWith("Dispatcher has no subscribers")) {
@@ -131,7 +125,7 @@ private List<String> insertMockLoggerInListener(
131125
return logList;
132126
}
133127

134-
private void verifyLogReceived(final List<String> logList) {
128+
private static void verifyLogReceived(final List<String> logList) {
135129
assertThat(logList.size() > 0).as("Failed to get expected exception").isTrue();
136130
boolean expectedExceptionFound = false;
137131
while (logList.size() > 0) {

spring-integration-mail/src/test/java/org/springframework/integration/mail/ImapMailReceiverTests.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,10 @@ public void testIdleWithServerGuts(ImapMailReceiver receiver, boolean mapped, bo
183183
receiver.setMaxFetchSize(1);
184184
receiver.setShouldDeleteMessages(false);
185185
receiver.setShouldMarkMessagesAsRead(true);
186-
receiver.setCancelIdleInterval(1);
187186
ThreadPoolTaskScheduler taskScheduler = new ThreadPoolTaskScheduler();
188187
setUpScheduler(receiver, taskScheduler);
189188
receiver.setUserFlag("testSIUserFlag");
190189
receiver.afterPropertiesSet();
191-
LogAccessor logger = spy(TestUtils.getPropertyValue(receiver, "logger", LogAccessor.class));
192-
new DirectFieldAccessor(receiver).setPropertyValue("logger", logger);
193190
ImapIdleChannelAdapter adapter = new ImapIdleChannelAdapter(receiver);
194191
QueueChannel channel = new QueueChannel();
195192
adapter.setOutputChannel(channel);
@@ -235,7 +232,6 @@ public void testIdleWithServerGuts(ImapMailReceiver receiver, boolean mapped, bo
235232
}
236233
assertThat(channel.receive(20000)).isNotNull(); // new message after idle
237234
assertThat(channel.receive(100)).isNull(); // no new message after second and third idle
238-
verify(logger).debug("Canceling IDLE");
239235

240236
adapter.stop();
241237
taskScheduler.shutdown();

0 commit comments

Comments
 (0)