Skip to content

Commit fb05c73

Browse files
committed
Upgrade dependencies; prepare for release
* Rework `FeedInboundChannelAdapterParserTests` for Java 17 compatibility
1 parent b443605 commit fb05c73

File tree

3 files changed

+31
-26
lines changed

3 files changed

+31
-26
lines changed

build.gradle

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ ext {
4646
modifiedFiles =
4747
files(grgit.status().unstaged.modified).filter{ f -> f.name.endsWith('.java') || f.name.endsWith('.kt') }
4848

49-
activeMqVersion = '5.16.3'
49+
activeMqVersion = '5.16.4'
5050
apacheSshdVersion = '2.7.0'
51-
aspectjVersion = '1.9.7'
52-
assertjVersion = '3.21.0'
51+
aspectjVersion = '1.9.8'
52+
assertjVersion = '3.22.0'
5353
assertkVersion = '0.25'
5454
avroVersion = '1.10.2'
5555
awaitilityVersion = '4.1.1'
@@ -63,7 +63,7 @@ ext {
6363
greenmailVersion = '1.6.5'
6464
groovyVersion = '3.0.9'
6565
hamcrestVersion = '2.2'
66-
hazelcastVersion = '4.2.3'
66+
hazelcastVersion = '4.2.4'
6767
hibernateVersion = '5.5.9.Final'
6868
hsqldbVersion = '2.6.0'
6969
h2Version = '1.4.200'
@@ -83,7 +83,7 @@ ext {
8383
lettuceVersion = '6.1.6.RELEASE'
8484
log4jVersion = '2.17.1'
8585
mailVersion = '1.6.7'
86-
micrometerVersion = '1.7.8'
86+
micrometerVersion = '1.7.9'
8787
mockitoVersion = '3.12.4'
8888
mongoDriverVersion = '4.3.2'
8989
mysqlVersion = '8.0.27'
@@ -99,14 +99,14 @@ ext {
9999
smackVersion = '4.3.5'
100100
soapVersion = '1.4.0'
101101
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.3.14'
102-
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : '2021.0.8'
103-
springKafkaVersion = '2.7.10'
102+
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : '2021.0.9'
103+
springKafkaVersion = '2.7.11'
104104
springRetryVersion = '1.3.1'
105-
springSecurityVersion = project.hasProperty('springSecurityVersion') ? project.springSecurityVersion : '5.5.4'
106-
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.3.15'
105+
springSecurityVersion = project.hasProperty('springSecurityVersion') ? project.springSecurityVersion : '5.5.5'
106+
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.3.16'
107107
springWsVersion = '3.1.2'
108-
testcontainersVersion = '1.16.2'
109-
tomcatVersion = '9.0.56'
108+
testcontainersVersion = '1.16.3'
109+
tomcatVersion = '9.0.58'
110110
xmlUnitVersion = '2.8.2'
111111
xstreamVersion = '1.4.17'
112112

@@ -222,6 +222,11 @@ configure(javaProjects) { subproject ->
222222
options.fork = true
223223
}
224224

225+
tasks.withType(Javadoc) {
226+
options.addBooleanOption('Xdoclint:syntax', true) // only check syntax with doclint
227+
options.addBooleanOption('Werror', true) // fail build on Javadoc warnings
228+
}
229+
225230
eclipse {
226231
project {
227232
natures += 'org.springframework.ide.eclipse.core.springnature'
@@ -349,7 +354,7 @@ configure(javaProjects) { subproject ->
349354

350355
checkstyle {
351356
configDirectory.set(rootProject.file('src/checkstyle'))
352-
toolVersion = project.hasProperty('checkstyleVersion') ? project.checkstyleVersion : '9.2'
357+
toolVersion = project.hasProperty('checkstyleVersion') ? project.checkstyleVersion : '9.3'
353358
}
354359

355360
jar {
@@ -996,6 +1001,7 @@ task api(type: Javadoc) {
9961001
options.overview = 'src/api/overview.html'
9971002
options.stylesheetFile = file('src/api/stylesheet.css')
9981003
options.links(project.ext.javadocLinks)
1004+
options.addBooleanOption('Xdoclint:syntax', true) // only check syntax with doclint
9991005
source javaProjects.collect { project ->
10001006
project.sourceSets.main.allJava
10011007
}

spring-integration-feed/src/test/java/org/springframework/integration/feed/config/FeedInboundChannelAdapterParserTests-file-usage-context.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
<bean id="metadataStore" class="org.springframework.integration.metadata.PropertiesPersistingMetadataStore">
2323
<property name="baseDirectory"
24-
value="#{T (org.springframework.integration.feed.config.FeedInboundChannelAdapterParserTests).tempFolder.root.absolutePath}"/>
24+
value="#{T (org.springframework.integration.feed.config.FeedInboundChannelAdapterParserTests).tempFolder.absolutePath}"/>
2525
</bean>
2626

2727
</beans>

spring-integration-feed/src/test/java/org/springframework/integration/feed/config/FeedInboundChannelAdapterParserTests.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2019 the original author or authors.
2+
* Copyright 2002-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,17 +19,16 @@
1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.mockito.Mockito.atLeast;
2121
import static org.mockito.Mockito.spy;
22-
import static org.mockito.Mockito.times;
2322
import static org.mockito.Mockito.verify;
2423

24+
import java.io.File;
2525
import java.util.Properties;
2626
import java.util.concurrent.CountDownLatch;
2727
import java.util.concurrent.TimeUnit;
2828

29-
import org.junit.ClassRule;
30-
import org.junit.Ignore;
31-
import org.junit.Test;
32-
import org.junit.rules.TemporaryFolder;
29+
import org.junit.jupiter.api.Disabled;
30+
import org.junit.jupiter.api.Test;
31+
import org.junit.jupiter.api.io.TempDir;
3332
import org.mockito.Mockito;
3433

3534
import org.springframework.context.ConfigurableApplicationContext;
@@ -58,8 +57,8 @@
5857
*/
5958
public class FeedInboundChannelAdapterParserTests {
6059

61-
@ClassRule
62-
public static final TemporaryFolder tempFolder = new TemporaryFolder();
60+
@TempDir
61+
public static File tempFolder;
6362

6463

6564
private static CountDownLatch latch;
@@ -91,20 +90,20 @@ public void validateSuccessfulHttpConfigurationWithCustomMetadataStore() {
9190
@Test
9291
public void validateSuccessfulNewsRetrievalWithFileUrlAndMessageHistory() throws Exception {
9392
//Test file samples.rss has 3 news items
94-
latch = spy(new CountDownLatch(3));
93+
latch = new CountDownLatch(3);
9594
ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext(
9695
"FeedInboundChannelAdapterParserTests-file-usage-context.xml", this.getClass());
9796
latch.await(10, TimeUnit.SECONDS);
98-
verify(latch, times(3)).countDown();
97+
assertThat(latch.getCount()).isEqualTo(0);
9998
context.close();
10099

101100
// since we are not deleting the persister file
102101
// in this iteration no new feeds will be received and the latch will timeout
103-
latch = spy(new CountDownLatch(3));
102+
latch = new CountDownLatch(3);
104103
context = new ClassPathXmlApplicationContext(
105104
"FeedInboundChannelAdapterParserTests-file-usage-context.xml", this.getClass());
106105
latch.await(500, TimeUnit.MILLISECONDS);
107-
verify(latch, times(0)).countDown();
106+
assertThat(latch.getCount()).isEqualTo(3);
108107

109108
SourcePollingChannelAdapter adapter = context.getBean("feedAdapterUsage", SourcePollingChannelAdapter.class);
110109
assertThat(TestUtils.getPropertyValue(adapter, "source.syndFeedInput.preserveWireFeed", Boolean.class))
@@ -114,7 +113,7 @@ public void validateSuccessfulNewsRetrievalWithFileUrlAndMessageHistory() throws
114113
}
115114

116115
@Test
117-
@Ignore // goes against the real feed
116+
@Disabled("Goes against the real feed")
118117
public void validateSuccessfulNewsRetrievalWithHttpUrl() throws Exception {
119118
final CountDownLatch latch = new CountDownLatch(3);
120119
MessageHandler handler = spy(message -> latch.countDown());

0 commit comments

Comments
 (0)