GH-386 - Prefer MongoTemplate.findAndModify(…) over ….updateFirst(…).

Original pull request: GH-380.

Author: nkolosnjaji

spring-modulith-events/spring-modulith-events-mongodb/src/main/java/org/springframework/modulith/events/mongodb/MongoDbEventPublicationRepository.java

@@ -27,6 +27,8 @@
 import org.springframework.data.domain.Sort;
 import org.springframework.data.mongodb.core.MongoTemplate;
 import org.springframework.data.mongodb.core.query.Criteria;
+import org.springframework.data.mongodb.core.query.CriteriaDefinition;
+import org.springframework.data.mongodb.core.query.Query;
 import org.springframework.data.mongodb.core.query.Update;
 import org.springframework.data.util.TypeInformation;
 import org.springframework.modulith.events.core.EventPublication;
@@ -79,14 +81,13 @@ public void markCompleted(Object event, PublicationTargetIdentifier identifier,
 		var criteria = byEventAndListenerId(event, identifier);
 		var update = Update.update("completionDate", completionDate);
 
-		mongoTemplate.updateFirst(query(criteria), update, MongoDbEventPublication.class);
+		mongoTemplate.findAndModify(defaultQuery(criteria), update, MongoDbEventPublication.class);
 	}
 
 	@Override
 	public List<EventPublication> findIncompletePublications() {
 
-		var query = query(where("completionDate").isNull())
-				.with(Sort.by("publicationDate").ascending());
+		var query = defaultQuery(where("completionDate").isNull());
 
 		return mongoTemplate.find(query, MongoDbEventPublication.class).stream() //
 				.map(this::documentToDomain) //
@@ -132,7 +133,7 @@ private List<MongoDbEventPublication> findDocumentsByEventAndTargetIdentifierAnd
 			Object event, PublicationTargetIdentifier targetIdentifier) {
 
 		var criteria = byEventAndListenerId(event, targetIdentifier);
-		var query = query(criteria).with(Sort.by("publicationDate").ascending());
+		var query = defaultQuery(criteria);
 
 		return mongoTemplate.find(query, MongoDbEventPublication.class);
 	}
@@ -159,6 +160,10 @@ private EventPublication documentToDomain(MongoDbEventPublication document) {
 		return new MongoDbEventPublicationAdapter(document);
 	}
 
+	private static Query defaultQuery(CriteriaDefinition criteria) {
+		return query(criteria).with(Sort.by("publicationDate").ascending());
+	}
+
 	private static class MongoDbEventPublicationAdapter implements EventPublication {
 
 		private final MongoDbEventPublication publication;