Should Hibernate Validator be required?

[piotrooo]

With a very simple application:

dependencies {
    implementation 'org.springframework.boot:spring-boot-starter'

    implementation 'org.springframework.shell:spring-shell-starter-jansi:4.0.0-SNAPSHOT'
}

I get:

***************************
APPLICATION FAILED TO START
***************************

Description:

The Bean Validation API is on the classpath but no implementation could be found

Action:

Add an implementation, such as Hibernate Validator, to the classpath

I'm not sure whether a validator implementation is a hard requirement.

If it is, should it be included (or pulled in transitively) by the core module?

[fmbenhassine]

Ideally, the entire validation feature should be optional (not everyone uses the bean validation API to validate commands). So the dependency to jakarta.validation-api should be optional and added (in addition to an implementation like hibernate validator) only when needed. But I am not sure if this is feasible as currently implemented (same as v3). We might need a separate module for that.

[fmbenhassine]

I'm not sure whether a validator implementation is a hard requirement.

That was the case in v3, see https://central.sonatype.com/artifact/org.springframework.shell/spring-shell-core/3.4.1/dependencies

If it is, should it be included (or pulled in transitively) by the core module?

So I guess yes for now.