Skip to content

Commit 6103b76

Browse files
committed
Fix #121; respect truthiness of filterFunction.
1 parent 8aad3a4 commit 6103b76

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

crossfilter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(function(exports){
2-
crossfilter.version = "1.3.7";
2+
crossfilter.version = "1.3.8";
33
function crossfilter_identity(d) {
44
return d;
55
}
@@ -825,7 +825,7 @@ function crossfilter() {
825825
removed = [];
826826

827827
for (i = 0; i < n; ++i) {
828-
if (!(filters[k = index[i]] & one) ^ (x = f(values[i], i))) {
828+
if (filters[k = index[i]] & one ^ !(x = f(values[i], i))) {
829829
if (x) filters[k] &= zero, added.push(k);
830830
else filters[k] |= one, removed.push(k);
831831
}

crossfilter.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "crossfilter",
3-
"version": "1.3.7",
3+
"version": "1.3.8",
44
"description": "Fast multidimensional filtering for coordinated views.",
55
"keywords": [
66
"square",

src/crossfilter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ function crossfilter() {
297297
removed = [];
298298

299299
for (i = 0; i < n; ++i) {
300-
if (!(filters[k = index[i]] & one) ^ (x = f(values[i], i))) {
300+
if (filters[k = index[i]] & one ^ !(x = f(values[i], i))) {
301301
if (x) filters[k] &= zero, added.push(k);
302302
else filters[k] |= one, removed.push(k);
303303
}

0 commit comments

Comments
 (0)