Fix commit fails the negative test in `lighttpd-bug-1948-1949`

[afsafzal]

Fixed version running n1:

mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
mod_proxy_core_address.c.158: (trace) resolving 127.0.0.1 on port 1026
mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
2018-02-23 20:14:22: (server.c.1445) WARNING: unknown config-key: auth.backend.ldap.url (ignored) 
./request.t .. 1/43 # status failed: expected '200', got '400'

#   Failed test 'Hostname in first line as https url'
#   at ./request.t line 104.
# status failed: expected '400', got '200'
# status failed: expected '400', got '200'
# status failed: expected '400', got '200'
# status failed: expected '304', got '200'
# Looks like you failed 1 test of 43.
./request.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/43 subtests 
        (1 TODO test unexpectedly succeeded)

Test Summary Report
-------------------
./request.t (Wstat: 256 Tests: 43 Failed: 1)
  Failed test:  12
  TODO passed:   14
  Non-zero exit status: 1
Files=1, Tests=43,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.03 cusr  0.03 csys =  0.09 CPU)
Result: FAIL
Failed 1/1 test programs. 1/43 subtests failed.
/experiment

[afsafzal]

output of running ./request.t:

mod_proxy_core_address.c.158: (trace) resolving 127.0.0.1 on port 1026
mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
mod_proxy_core_address.c.158: (trace) resolving 127.0.0.1 on port 1026
mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
2018-02-23 20:51:54: (server.c.1445) WARNING: unknown config-key: auth.backend.ldap.url (ignored) 
ok 1 - Starting lighttpd
ok 2 - file not found
ok 3 - file not found + querystring
ok 4 - GET, content == 12345, mimetype text/plain
ok 5 - GET, content == 12345, mimetype text/html
ok 6 - GET, content == 12345, mimetype application/octet-stream
ok 7 - POST request, no Content-Length
ok 8 - POST request, empty request-body
ok 9 - HEAD request, no content
ok 10 - HEAD request, mimetype text/html, content-length
ok 11 - Hostname in first line, HTTP/1.1
# status failed: expected '200', got '400'
not ok 12 - Hostname in first line as https url
#   Failed test 'Hostname in first line as https url'
#   at ./request.t line 104.
ok 13 - HEAD request, file-not-found, query-string
ok 14 - Continue, Expect # TODO The test is broken, the feature works
ok 15 - GET, Range 0-3
ok 16 - GET, Range -3
ok 17 - GET, Range 3-
ok 18 - GET, Range 0-1,3-4
ok 19 - GET, Range 0--
ok 20 - GET, Range -2-3
ok 21 - GET, Range -0
ok 22 - GET, Range start out of range
ok 23 - larger headers
ok 24 - Duplicate Host headers, Bug \#25
ok 25 - Duplicate Content-Length headers
ok 26 - Duplicate If-None-Match headers
# status failed: expected '400', got '200'
not ok 27 - Duplicate Content-Type headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate Content-Type headers'
#   at ./request.t line 297.
# status failed: expected '400', got '200'
not ok 28 - Duplicate Range headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate Range headers'
#   at ./request.t line 306.
# status failed: expected '400', got '200'
not ok 29 - Duplicate If-Modified-Since headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate If-Modified-Since headers'
#   at ./request.t line 315.
ok 30 - GET, Range with range-requests-disabled
ok 31 - GET with Content-Length
ok 32 - OPTIONS with Content-Length
ok 33 - OPTIONS for RTSP
ok 34 - HEAD with Content-Length
# status failed: expected '304', got '200'
not ok 35 - Duplicate If-Mod-Since, with equal timestamps # TODO to be fixed later
#   Failed (TODO) test 'Duplicate If-Mod-Since, with equal timestamps'
#   at ./request.t line 372.
ok 36 - invalid chars in Header values (bug \#1286)
ok 37 - empty If-Modified-Since
ok 38 - broken If-Modified-Since
ok 39 - broken If-Modified-Since
ok 40 - Similar Headers (bug \#1287)
ok 41 - If-Modified-Since
ok 42 - Status 304 has no Content-Length (\#1002)
ok 43 - Stopping lighttpd
# Looks like you failed 1 test of 43.

[ChrisTimperley]

@afsafzal Is the output of request.t for the buggy or patched version of the program?

[afsafzal]

patched version.

[ChrisTimperley]

Please could you post the output for the buggy version? Then we can take a look at the diffs and see if the patched version passes at least one previously failing tests.

[afsafzal]

output of running request.t on buggy version:

mod_proxy_core_address.c.158: (trace) resolving 127.0.0.1 on port 1026
mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
mod_proxy_core_address.c.158: (trace) resolving 127.0.0.1 on port 1026
mod_proxy_core_address.c.63: (trace) adding 127.0.0.1:1026 to the address-pool
2018-03-01 18:24:41: (server.c.1445) WARNING: unknown config-key: auth.backend.ldap.url (ignored) 
ok 1 - Starting lighttpd
ok 2 - file not found
ok 3 - file not found + querystring
ok 4 - GET, content == 12345, mimetype text/plain
ok 5 - GET, content == 12345, mimetype text/html
ok 6 - GET, content == 12345, mimetype application/octet-stream
ok 7 - POST request, no Content-Length
ok 8 - POST request, empty request-body
ok 9 - HEAD request, no content
ok 10 - HEAD request, mimetype text/html, content-length
ok 11 - Hostname in first line, HTTP/1.1
# status failed: expected '200', got '400'
not ok 12 - Hostname in first line as https url
#   Failed test 'Hostname in first line as https url'
#   at ./request.t line 104.
ok 13 - HEAD request, file-not-found, query-string
ok 14 - Continue, Expect # TODO The test is broken, the feature works
ok 15 - GET, Range 0-3
ok 16 - GET, Range -3
ok 17 - GET, Range 3-
ok 18 - GET, Range 0-1,3-4
ok 19 - GET, Range 0--
ok 20 - GET, Range -2-3
ok 21 - GET, Range -0
ok 22 - GET, Range start out of range
ok 23 - larger headers
ok 24 - Duplicate Host headers, Bug \#25
ok 25 - Duplicate Content-Length headers
ok 26 - Duplicate If-None-Match headers
# status failed: expected '400', got '200'
not ok 27 - Duplicate Content-Type headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate Content-Type headers'
#   at ./request.t line 297.
# status failed: expected '400', got '200'
not ok 28 - Duplicate Range headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate Range headers'
#   at ./request.t line 306.
# status failed: expected '400', got '200'
not ok 29 - Duplicate If-Modified-Since headers # TODO Duplicate checks are broken for now, ignore them
#   Failed (TODO) test 'Duplicate If-Modified-Since headers'
#   at ./request.t line 315.
ok 30 - GET, Range with range-requests-disabled
ok 31 - GET with Content-Length
ok 32 - OPTIONS with Content-Length
ok 33 - OPTIONS for RTSP
ok 34 - HEAD with Content-Length
# status failed: expected '304', got '200'
not ok 35 - Duplicate If-Mod-Since, with equal timestamps # TODO to be fixed later
#   Failed (TODO) test 'Duplicate If-Mod-Since, with equal timestamps'
#   at ./request.t line 372.
ok 36 - invalid chars in Header values (bug \#1286)
ok 37 - empty If-Modified-Since
ok 38 - broken If-Modified-Since
ok 39 - broken If-Modified-Since
ok 40 - Similar Headers (bug \#1287)
ok 41 - If-Modified-Since
# header 'content-length' MUST not be set
not ok 42 - Status 304 has no Content-Length (\#1002)
#   Failed test 'Status 304 has no Content-Length (\#1002)'
#   at ./request.t line 415.
ok 43 - Stopping lighttpd
# Looks like you failed 2 tests of 43.

[afsafzal]

@ChrisTimperley looks like buggy version is failing 1 extra test

[ChrisTimperley]

@afsafzal That's good news. In that case, we need to modify request.t accordingly. The challenge is to do so without introducing any regressions to the other lighttpd scenarios.