Unhelpful "Closing delimiter foo not found" message

[mbanck]

I'm getting the above message on a file, but it doesn't tell me which line or any context. Is this some internal error, or a possibly a legit problem (php -l on the file says "no syntax errors detected"). If the former, I think php7cc should print out additional information so that the offending part can be easily identified.

[mbanck]

Ok, so by manually bisecting the file I figured out it is this line:

$url = preg_replace('s/^internal:/', '', $url);

which makes sense, as it complains about s as delimiter. AIUI, the 's' is a PCRE modifier (see http://php.net/manual/en/reference.pcre.pattern.modifiers.php), is this a legit error from php7cc or a false positive?

[sstalle]

Seems like this is a legit error. I tried running your code on PHP 7.0.24 and got:

Warning: preg_replace(): Delimiter must not be alphanumeric or backslash in /var/app/test.php on line 4

Although you are right that s is a valid modifier, I don't think modifiers are allowed before the opening delimiter. You probably have to move s to the end of the regexp like this: '/^internal:/s'.

[mbanck]

OK, right, I have changed the code in the meantime accordingly.

However, I still think php7cc should be more informative in this case, and report a line number e.g.