Support older versions of urllib3 (#1580)

Author: jsignell

pyproject.toml

@@ -54,7 +54,7 @@ dev = [
     "types-orjson>=3.6.2",
     "types-python-dateutil>=2.9.0.20241003",
     "types-urllib3>=1.26.25.14",
-    "urllib3>=2.3.0",
+    "urllib3>=1.26.19",
     "virtualenv>=20.26.6",
 ]
 docs = [

pystac/stac_io.py

@@ -286,9 +286,9 @@ def read_text_from_href(self, href: str) -> str:
         """Reads file as a UTF-8 string.
 
         If ``href`` has a "scheme" (e.g. if it starts with "https://") then this will
-        use :func:`urllib.request.urlopen` (or func:`urllib3.request` if available)
-        to open the file and read the contents; otherwise, :func:`open` will be used
-        to open a local file.
+        use :func:`urllib.request.urlopen` (or func:`urllib3.PoolManager().request`
+        if available) to open the file and read the contents; otherwise, :func:`open`
+        will be used to open a local file.
 
         Args:
 
@@ -299,7 +299,8 @@ def read_text_from_href(self, href: str) -> str:
             try:
                 logger.debug(f"GET {href} Headers: {self.headers}")
                 if HAS_URLLIB3:
-                    with urllib3.request(
+                    http = urllib3.PoolManager()
+                    with http.request(
                         "GET",
                         href,
                         headers={

tests/test_stac_io.py

@@ -117,7 +117,7 @@ class ReportingStacIO(DefaultStacIO, DuplicateKeyReportingMixin):
         assert str(excinfo.value), f'Found duplicate object name "key" in {src_href}'
 
 
-@unittest.mock.patch("pystac.stac_io.urllib3.request")
+@unittest.mock.patch("pystac.stac_io.urllib3.PoolManager.request")
 def test_headers_stac_io(request_mock: unittest.mock.MagicMock) -> None:
     stac_io = DefaultStacIO(headers={"Authorization": "api-key fake-api-key-value"})