Skip to content

feat!: Add new ListenerClass.pinnedNodePorts field #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 13, 2025
Merged

feat!: Add new ListenerClass.pinnedNodePorts field #1105

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1e9d75d
feat!: Add new `ListenerClass.stickyNodePorts` field
sbernauer Oct 7, 2025
16a07e1
changelog
sbernauer Oct 7, 2025
0b5e63c
Update crates/stackable-operator/src/crd/listener/class/mod.rs
sbernauer Oct 9, 2025
23a9028
Update crates/stackable-operator/src/crd/listener/class/mod.rs
sbernauer Oct 13, 2025
7d82c52
sticky -> pinning
sbernauer Oct 13, 2025
fa8aa89
pinning -> pinned
sbernauer Oct 13, 2025
6e2a6da
changelog
sbernauer Oct 13, 2025
eab4bfa
changelog
sbernauer Oct 13, 2025
247a951
Update crates/stackable-operator/src/crd/listener/class/mod.rs
sbernauer Oct 13, 2025
d966158
charts
sbernauer Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,18 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Added

- BREAKING: Add new `ListenerClass.stickyNodePorts` field ([#1105]).

[#1105]: https://github.com/stackabletech/operator-rs/pull/1105

## [0.99.0] - 2025-10-06

### Added

- Add CLI argument and env var to disable the end-of-support checker: `EOS_DISABLED` (`--eos-disabled`) ([#1101]).
- Add end-of-support checker ([#1096]).
- Add end-of-support checker ([#1096], [#1103]).
- The EoS checker can be constructed using `EndOfSupportChecker::new()`.
- Add new `MaintenanceOptions` and `EndOfSupportOptions` structs.
- Add new CLI arguments and env vars:
Expand Down
15 changes: 15 additions & 0 deletions crates/stackable-operator/crds/ListenerClass.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions crates/stackable-operator/src/crd/listener/class/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,19 @@ pub mod versioned {
/// Defaults to `HostnameConservative`.
#[serde(default = "ListenerClassSpec::default_preferred_address_type")]
pub preferred_address_type: core_v1alpha1::PreferredAddressType,

/// Wether a Pod exposed using a NodePort should be pinned to a specific Kubernetes node.
///
/// By pinning the Pod to a specific (stable) Kubernetes node, stable addresses can be
/// provided using NodePorts. The stickiness is achieved by listener-operator setting the
/// `volume.kubernetes.io/selected-node` annotation on the Listener PVC.
///
/// However, this only works on setups with long-living nodes. If your nodes are rotated on
/// a regular basis, the Pods previously running on a removed node will be stuck in Pending
/// until you delete the PVC with the stickiness.
///
/// Because of this we don't enable stickiness by default to support all environments.
#[serde(default)]
Copy link
Contributor

@nightkr nightkr Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dangerous default. Having it be configurable is one thing (I'd probably still be against it, but my vague opinion doesn't really count for much anymore :p), but unpinned + NodePort should be a big warning sign that you're doing something Weird and are probably using the wrong tool (and about to walk into a rake).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the person who looked at customer issues we had and said "let's change it". To me it sounds totally sane - otherwise I probably wouldn't have asked for this. Can you elaborate what I'm missing?

We've outlined the reasons a bit here: stackabletech/issues#770

And let me close by saying that your opinion does and will count going forward. Thanks for still looking into this. We do have jobs available if you'd like to be paid to work on this ;-)

pub sticky_node_ports: bool,
}
}
Loading